Harden and exercise the container release contract - #3111
Draft
Chris0Jeky wants to merge 4 commits into
Draft
Chris0Jeky wants to merge 4 commits into
Chris0Jeky wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Resolve the three release-container residuals in #1854:
v*tags that are not valid release semver beforedocker/metadata-actionprocesses them;Red → green evidence
RED — exact contract-only head. Commit
e36dc0cb6888c66ae4eff9b7ea895b497fcf59a7added the executable contract and required-lane wiring before release implementation changed. Main CI run34921632532, Release Workflow Contract job104230817506, first passed all 87/87 existing desktop release checks, then failed 7/7 new container checks for exactly the intended boundaries:release-container.ymlstill derived the version inline rather than calling a tested authority before metadata generation;set -euo pipefailand anEXITcleanup trap.GREEN candidate. Exact head
c8118b537f45b1214da33da731ef5550750912d7adds the resolver and consumes it from the workflow, then hardens the smoke step. Smart CI, Extended CI, and main CI are running; this PR remains draft until the complete exact-head matrix settles.Design
scripts/ci/resolve-container-version.shreceives the real Git ref. Tag refs must clear the sharedvalidate-release-tag.shgrammar, then lose only build metadata; non-tag manual rehearsals retain0.0.0-dev.docker/metadata-action, so malformedv*refs fail before image tags or publishing are computed.EXITtrap removestaskdeck-smokeon startup, health, extraction, assertion, or explicit-exit failures.Scope
Closes #1854