Compare semantic JCEF checksums - #144
Open
jinyiwei2012 wants to merge 2 commits into
Open
Conversation
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
Ultraworked with [Sisyphus](https://github.com/code-yeongyu/oh-my-openagent) Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Files.move(..., REPLACE_EXISTING)instead of uncheckedFile.renameTo(...)Fixes #143.
Why
The MCEF mirror currently serves checksum files as PowerShell
Get-FileHashtable output containing headers, padding, line endings, and a CI runner path in addition to the actual 64-character hash.FileUtils.contentEquals(...)treats changes to any of those non-semantic bytes as a JCEF update and can trigger a complete runtime download even when the actual SHA-256 value is unchanged.Behavior preserved
Invalid remote content
The downloaded marker must contain exactly one standalone 64-character hexadecimal SHA-256 token. Missing, truncated, embedded-in-a-longer-hex-string, or multiple tokens are rejected. The temporary file is removed and an existing valid marker remains unchanged.
Tests
:common:test: 17 tests, 17 passedgit diff --check: passedScope
This PR intentionally does not change archive caching, resumable downloads, file locking, mirror selection, or the libraries path. Those are separate improvements from the semantic checksum comparison fixed here.
This change was developed with AI assistance and manually reviewed and verified against the current mirror artifacts and the Gradle test suite.