Skip to content

Fix direct sandbox merged-/usr startup and IPv6 binding#26

Open
LeonardSEO wants to merge 1 commit into
ClickHouse:mainfrom
LeonardSEO:codex/fix-runtime-issues
Open

Fix direct sandbox merged-/usr startup and IPv6 binding#26
LeonardSEO wants to merge 1 commit into
ClickHouse:mainfrom
LeonardSEO:codex/fix-runtime-issues

Conversation

@LeonardSEO

Copy link
Copy Markdown

Summary

This PR addresses the concrete runtime issues that can be fixed without changing the storage or egress architecture:

Validation

  • bash tests/start-direct-sandbox.test.sh
  • bash -n docker/start-direct-sandbox.sh tests/start-direct-sandbox.test.sh
  • npx --yes bun test api/src/config.test.ts
  • git diff --check

Scope notes

Issue #25 appears to be an injection/lifecycle race in the LibreChat integration: the first execution arrives with zero injected files, while the second has the resource file. It is not reproducibly fixable in this repository from the issue evidence alone.

Issues #15, #21, #11, and #6 require separate upstream design or infrastructure work (virtio-fs/libkrun descriptor lifecycle, Flux-compatible chart sourcing, object-storage migration, and a policy-controlled egress gateway respectively).

References: #22, #23, #24, #25, #15, #21, #11, #6

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@LeonardSEO
LeonardSEO marked this pull request as ready for review July 20, 2026 09:19
@danny-avila

Copy link
Copy Markdown
Collaborator

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5290dbd91b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +259 to +260
- name: SANDBOX_BIND_HOST
value: {{ .Values.workerSandbox.sandbox.bindHost | default "0.0.0.0" | quote }}

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Allow SANDBOX_BIND_HOST through the microVM launcher

When this chart runs with the default workerSandbox.kvmEnabled: true, this new env var is set only on the outer sandbox-runner container; the microVM guest receives only variables allowed by launcher/src/main.rs:is_allowed_guest_env_key, and that allowlist currently includes PORT but not SANDBOX_BIND_HOST. As a result, setting workerSandbox.sandbox.bindHost: "::" for an IPv6-only cluster is silently dropped before api/src/config.ts runs, so the sandbox API still binds 0.0.0.0 unless KVM is disabled or the launcher allowlist is updated.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants