Validate stream column against selected columns size - #29
Merged
Merged
Conversation
PedroTadim
added a commit
to ClickHouse/ClickHouse
that referenced
this pull request
Oct 2, 2026
A stripe footer can declare a stream for a column id that is not in the file's type tree. `orc::ReaderImpl::preBuffer` indexed the selected-column mask with that id, which failed the libc++ hardening assertion and aborted the server. Stripes are prebuffered only for remote reads, so the crash needed `s3` or a data lake table function; `file` and `url` read the same file normally. The library now throws `orc::ParseError`. The test reads a 569-byte ORC file, embedded in the test, whose stripe footer declares a stream for column 20 in a file with 5 columns, through `s3`. Related: ClickHouse/orc#29 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?