Skip to content

raise coverage, optimize tests #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serprex merged 2 commits into from
Sep 30, 2026
Merged

raise coverage, optimize tests #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc07532
extend plans, include some verification
serprex Sep 30, 2026
79eba27
raise coverage, optimize tests
serprex Sep 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,7 +283,7 @@ jobs:
- name: Coverage summary
working-directory: walshadow
env:
MAX_MISSED_LINES: 3515
MAX_MISSED_LINES: 3130
run: |
awk -F'[:,]' -v max="$MAX_MISSED_LINES" '
/^DA:/ { f++; if ($3 > 0) h++ }
Expand Down
23 changes: 23 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,8 @@ name = "spool_read"
harness = false

[dev-dependencies]
# Pre-main tracing subscriber for tests
ctor = "1.0.13"
tempfile = "3"
# Enable paused time for batch deadline tests
tokio = { version = "1", features = ["test-util"] }
Expand Down
12 changes: 6 additions & 6 deletions plans/INDEX.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,13 @@ writes. A documented limitation does not imply code rejects it

| Plan | Next step |
|---|---|
| [Schema changes](schema.md) | Reject unsupported transitions before destination effects |
| [Value coercion](value_coercion.md) | Reject Decimal precision loss and signedness corruption; fix String NaN defaults; prove rejection recovery |
| [Runtime configuration](runtime_config.md) | Locate owning UI and reproduce stale/dead state; expose existing controls there |
| [Schema changes](schema.md) | Fix rename routing and changed-key tombstones; reject keyless/unlogged gaps before effects |
| [Tablespaces](tablespaces.md) | Reject unsafe layouts before bootstrap, then add complete support |
| [Catalog completeness](catalog.md) | Stop when a surviving relation has lost buffered payload |
| [Bootstrap visibility](bootstrap.md) | Prove pending-row recovery across load modes and restart |
| [Verification](verification.md) | Prove outage, restart, and WAL-version behavior |
| [Verification](verification.md) | Prove value fidelity and restart without skipping WAL |
| [100% line coverage](coverage100.md) | Close fixture, live-system, CLI, and fault-path gaps, then enforce 100% |

## Further work
Expand All @@ -34,13 +36,11 @@ writes. A documented limitation does not imply code rejects it
|---|---|
| [Multi-database loads and metrics](multi_database.md) | Extend heap-page bootstrap and backup loads beyond primary database, attribute metrics |
| [Fuzzing](fuzzing.md) | Find parser and schema-transition interactions beyond fixed regressions |
| [Performance](performance.md) | Locate bottlenecks before changing concurrency or allocation |
| [Runtime configuration](runtime_config.md) | Configure destination DDL, codecs, and settings; add commands and explain effective config |
| [Failover](failover.md) | Continue after unplanned promotion or across archived timeline changes |
| [Performance](performance.md) | Establish healthy sustained WAL baseline with exact reconciliation before tuning |
| [Failover](failover.md) | Fence unplanned promotion and prove remaining archive/restart fault cases |
| [Shadow TOAST reclamation](shadow_toast.md) | Keep historical values readable under lag and restart |
| [Replay callback](custom_rmgr.md) | Reduce measured command-boundary capture stalls |
| [Dependencies](dependencies.md) | Replace generic protocol code when an adapter preserves behavior |
| [Value coercion](value_coercion.md) | Validate destination domains and align fast defaults with row substitution |
| [Tier 2 containers](tier2.md) | Remove shadow round trips for array, map, and vector columns |
| [Optional capabilities](extensions.md) | Meet a concrete routing, export, vector, or durability requirement |

Expand Down
6 changes: 6 additions & 0 deletions plans/catalog.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ A markerless record can be tracked without its payload while its relation is
unknown. If that relation resolves to an ordinary surviving table at commit,
resolution currently warns that rows were not mirrored and continues

Reproduced at `1267db7` without PostgreSQL: seed `DescriptorLog` with an ordinary
relation, call `track_unresolvable(77, 150, rfn)`, then
`resolve_stash(..., 77, &[], 1000, ...)`. Resolution returns `Ok(())` despite
missing payload. This establishes missing rejection, not an end-to-end durable
cursor advance; assert that boundary when adding regression

Return an error for that outcome. Preserve legitimate discard behavior when
relation was born and dropped within transaction. Test both branches and prove
failure cannot advance durable progress past lost rows
Expand Down
Loading
Loading