Plotting updates (scorecards, paper revision) - #77
Open
treigerm wants to merge 18 commits into
Open
Conversation
juntyr
reviewed
Sep 2, 2026
| ): | ||
| """Creates all the plots which only depend on a single variable.""" | ||
| for dataset in all_results["Dataset"].unique(): | ||
| if dataset != "cmip6-access-tos": |
Member
Author
There was a problem hiding this comment.
Ah this is some quick and dirty filtering that shouldn't have slipped in. Removed now.
| # Passing a file handle hides the suffix from matplotlib, so it | ||
| # falls back to the default PNG format and writes PNG bytes into | ||
| # a .pdf file. Pass the Path directly so the format is inferred. | ||
| fig.savefig(outfile, dpi=300, bbox_inches="tight") |
Collaborator
There was a problem hiding this comment.
We could still pass f but also set format="pdf", which would still support the virtual file system
Member
Author
|
Thanks for the review @juntyr , I've made the changes! |
Collaborator
|
@treigerm You can merge this PR once you're happy with it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes some changes to the plotting code, namely:
I have also sneaked in a change to compress.py which allows to overwrite the existing compressor results (useful when re-running the compression pipeline).