Skip to content

chore: make samply debug info server timeout much shorter - #485

Merged
GuillaumeLagrange merged 2 commits into
mainfrom
test-time-troubleshoot
Jul 28, 2026
Merged

chore: make samply debug info server timeout much shorter#485
GuillaumeLagrange merged 2 commits into
mainfrom
test-time-troubleshoot

Conversation

@GuillaumeLagrange

@GuillaumeLagrange GuillaumeLagrange commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@GuillaumeLagrange GuillaumeLagrange changed the title chore: remove electronjs.org symbol breakpad chore: remove electronjs.org symbol server Jul 28, 2026
@GuillaumeLagrange GuillaumeLagrange changed the title chore: remove electronjs.org symbol server chore: remove dead electronjs.org symbol server Jul 28, 2026
@greptile-apps

greptile-apps Bot commented Jul 28, 2026

Copy link
Copy Markdown

Greptile Summary

Updates the Samply CodSpeed submodule to shorten debug-info server timeouts and changes executor test binaries to use Cargo’s default build profile.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
crates/samply-codspeed Advances the submodule revision to the upstream commit that reduces debug-info server timeout durations.
src/executor/tests.rs Removes the release-profile override when building executor test binaries; no release-specific test contract was identified.

Reviews (2): Last reviewed commit: "Revert "chore: make tests run release bu..." | Re-trigger Greptile

@GuillaumeLagrange
GuillaumeLagrange removed the request for review from not-matthias July 28, 2026 14:56
@codspeed-hq

codspeed-hq Bot commented Jul 28, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

✅ 17 untouched benchmarks


Comparing test-time-troubleshoot (f24b97a) with main (8d6fffb)

Open in CodSpeed

@GuillaumeLagrange GuillaumeLagrange changed the title chore: remove dead electronjs.org symbol server chore: make samply debug info server timeout much shorter Jul 28, 2026
@GuillaumeLagrange
GuillaumeLagrange merged commit f24b97a into main Jul 28, 2026
23 checks passed
@GuillaumeLagrange
GuillaumeLagrange deleted the test-time-troubleshoot branch July 28, 2026 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants