Conversation
…thentication (CWE-522) A null Authentication argument is treated as ACL.SYSTEM by the Credentials plugin, so the lookup returns secrets the caller and current item may not be allowed to use.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Detects
CredentialsProvider.lookupCredentialsinvoked with a null authentication argument.In the Jenkins Credentials plugin, a null
Authenticationis treated asACL.SYSTEM, so the lookup returns credentials the current user and the current item may not be allowed to use. Callers should pass the requestor's authentication and the owningItem/ItemGroup(for exampleCredentialsProvider.findCredentialById(id, type, item)).Rule
codevigilant.java.jenkins.credentials.lookup-null-authenticationjava/jenkins/credentials/lookup-null-authentication.yamlValidation
semgrep --validateon the new file: passlookupCredentials(..., null, ...)): fireslookupCredentialswith a non-null Authentication): silentjava/and--config auto: 0 hits on the positive repro (not a community duplicate)Notes
Single rule file on a branch created from upstream/main. No project-specific evidence.