Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a Jenkins-oriented Java rule for stored XSS via changelog markup:
codevigilant.java.jenkins.xss.markuptext-addmarkup-nonliteralFires when
hudson.MarkupText.addMarkup(start, end, left, right)is calledwith a non-literal start-tag argument.
addMarkupinserts the start and endstrings as raw HTML around changelog text. When the start tag is built from
ticket URLs, issue identifiers, or other config/untrusted strings without
escaping, a quote or angle-bracket in that value breaks out of the
attribute/element.
The rule does not fire when the start tag is a string literal (static markup).
Validated with
semgrep --validate; tested against a positive repro(non-literal start tag — fires) and a sanitized negative (literal
"<b>"/"</b>"— no findings).