Skip to content

Bump core to 35ab4b8 - #148

Merged
Kinflou merged 1 commit into
mainfrom
deps/core-35ab4b8
Nov 11, 2026
Merged

Kinflou merged 1 commit into
mainfrom
deps/core-35ab4b8

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 11, 2026

Copy link
Copy Markdown
Member

Moves comline-core from 1669a2f to 35ab4b8 (core master); comline-codegen, comline-doc-markdown, comline-doc-html to generation 0977d7a, comline-codegen-rust to comline-rust 6405b44 and comline-codegen-typescript to comline-typescript 9496b1e. Those are the heads of each repo's deps/core-35ab4b8 branch, and both generators pin that same generation rev.

  • Cargo.toml, tests/fixtures/generators/Cargo.toml: pins bumped, Cargo.lock and the generators fixture's lock re-resolved by Cargo (no cargo update).
  • No code changes needed; cargo check --all-targets is clean.
  • The comline-runtime-conformance pin (runtime 3b9cc9d) is unchanged.

@Kinflou
Kinflou marked this pull request as ready for review November 11, 2026 14:21
@Kinflou
Kinflou merged commit 4513132 into main Nov 11, 2026
5 checks passed
Kinflou added a commit that referenced this pull request Nov 14, 2026
… from generation 922847b (#161)

* Test nested-schema protocols and a dependency's jsonrpc names (generation#147, #148)

On the old generation pin: a package with a protocol in src/chat/admin.ids
is refused for want of facts, and a dependency's jsonrpc method name clashes
with the package's own.

* Pin generation 922847b and the generators that match it; check clashes among the package's own protocols

The build's method-name clash check takes the package's dependency names
from its compiled context, as comline generation does, so a dependency's
jsonrpc protocol is no clash for the package's own. The test now gives the
package a client-provided protocol, which is what puts its jsonrpc
protocols on a connection.

---------

Co-authored-by: Kinflou <ossdevlev@proton.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant