Repository navigation
Bump core to 35ab4b8 - #148
Merged
Merged
Conversation
Kinflou
marked this pull request as ready for review
November 11, 2026 14:21
Kinflou
added a commit
that referenced
this pull request
Nov 14, 2026
… from generation 922847b (#161) * Test nested-schema protocols and a dependency's jsonrpc names (generation#147, #148) On the old generation pin: a package with a protocol in src/chat/admin.ids is refused for want of facts, and a dependency's jsonrpc method name clashes with the package's own. * Pin generation 922847b and the generators that match it; check clashes among the package's own protocols The build's method-name clash check takes the package's dependency names from its compiled context, as comline generation does, so a dependency's jsonrpc protocol is no clash for the package's own. The test now gives the package a client-provided protocol, which is what puts its jsonrpc protocols on a connection. --------- Co-authored-by: Kinflou <ossdevlev@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves
comline-corefrom 1669a2f to 35ab4b8 (core master);comline-codegen,comline-doc-markdown,comline-doc-htmlto generation 0977d7a,comline-codegen-rustto comline-rust 6405b44 andcomline-codegen-typescriptto comline-typescript 9496b1e. Those are the heads of each repo'sdeps/core-35ab4b8branch, and both generators pin that same generation rev.Cargo.toml,tests/fixtures/generators/Cargo.toml: pins bumped,Cargo.lockand the generators fixture's lock re-resolved by Cargo (nocargo update).cargo check --all-targetsis clean.comline-runtime-conformancepin (runtime 3b9cc9d) is unchanged.