Repository navigation
CI: reusable workflows, hardening - #149
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 of the CI overhaul for this repository, following core#257 and runtime#120.
What moved
ci.yml: the copied stable job and the Windows/macOS/arm matrix are replaced by the reusablerust-ci.yml(ComlineProject/.github at 797d473, SHA-pinned), withtargets: wasm32-wasip1for the external-generator tests. It runs the stable/beta/nightly matrix on ubuntu-24.04, stable on ubuntu-24.04-arm, macos-15 and windows-2025, and a stable canary on ubuntu-26.04 that may fail without failing the run.lint.yml(new) calls the reusable lint (actionlint and the Renovate config check);renovate.json(new) extendsgithub>ComlineProject/.github:renovate-config.rust-toolchain.toml(new): exact1.99.1. The reusable matrix setsRUSTUP_TOOLCHAIN, which overrides the file.Hardening, every workflow
ubuntu-24.04,macos-15,windows-2025), no-latest.permissions: contents: read;contents: writeonly on the reportspublishjob.persist-credentials: falseon every checkout except the one inpublish, which pushes.timeout-minuteson every job.uses:pinned to a 40-hex SHA with a version comment (the same SHAs as core, including the observatory actions).dtolnay/rust-toolchain@stablebecame the pinned action withtoolchain: 1.99.1, so the jobs agree withrust-toolchain.toml.grep -rn 'apt-get\|brew install\|choco install\|curl .*| *sh' .github/is empty.What stayed local, and why
Lint(rustfmt, both clippy runs, the two fixture-crate rustfmt checks): the CI images have neither rustfmt nor clippy, and the reusable workflow doesn't run them. A VM job on the pinned 1.99.1.reports.yml(size, coverage, compile time, publish): VM jobs. The size and compile reports build a release binary and the coverage report needs llvm-cov's rustup component, which the images lack. The observatory actions' own innertaiki-e/install-action@v2is pinned inside the observatory, not here.Things to know
TestandTest (<os>)are nowrust / test (stable)andrust / test (<os>), and so on. If branch protection requires the old names, it needs updating (I changed no settings).Cargo.lockis untouched.Wall time (run start to finish)
The after figures are inflated by runner availability, not by the work. In the warm CI run the Windows job waited about four minutes for a runner and then took 4m57s; every other job finished within 3m40s of the start. Reports ran its three jobs one after another with roughly two minutes between them for the same reason. The after runs also do more than the before ones: beta, nightly and the canary are new jobs.