Skip to content

Take each generator's docs link from the generator (generation#137 step 1) - #155

Merged
Kinflou merged 3 commits into
mainfrom
cli/generator-docs-links
Nov 13, 2026
Merged

Kinflou merged 3 commits into
mainfrom
cli/generator-docs-links

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 13, 2026

Copy link
Copy Markdown
Member

Stage 3 of ComlineProject/generation#137 step 1: the CLI takes the per-language docs link from the generator instead of hardcoding it.

  • The note that a package has no Services / serve / connect (note_no_connection_protocols) no longer matches on the language name. It links to the page the generator names for Topic::Connections: a built-in generator's docs table, or the docs of the LanguageInfo an external generator's description offers for the target's language. A generator without the topic gets no link. The note's wording is unchanged.
  • Pins, in three commits:
    • comline-core 35ab4b8 -> 263e583; comline-codegen, comline-doc-markdown, comline-doc-html -> generation 3ad2c79; comline-codegen-rust -> 3497635; comline-codegen-typescript -> 20bad45. The test generator fixtures pin the same revs. These point at heads of the open generation#139, comline-rust#123 and comline-typescript#163, which merge with merge commits. Cargo.lock moves only comline-* git crates.
    • comline doc: core's changelog now takes the encodings each version sees, so doc carries each version's stored configs (own and dependencies') and reads them from there.
  • The module commands/generate.rs is renamed commands/generation.rs (and tests/cli/generate.rs -> generation.rs), to match the command.
  • The repo owner's in-progress formatting is folded in: blank lines between steps, struct fields and enum variants; the crate's own imports before the external ones in generation.rs and history.rs; a blank line after the consts in external.rs.
  • Tests: the built-in rust and typescript links in the note; an external generator whose description carries a connections doc shows it, and one without gets none (the hostile fixture gains docs and plain modes).

comline-core 35ab4b8 -> 263e583; comline-codegen, comline-doc-markdown
and comline-doc-html -> generation 3ad2c79; comline-codegen-rust and
comline-codegen-typescript to the heads that pin them. The test generator
fixtures pin the same revs.

core's changelog now takes the encodings each version sees alongside its
schemas and config, so `doc` carries each version's stored configs (own and
its dependencies') and reads the encodings from them.
…matting

commands/generate.rs -> commands/generation.rs and tests/cli/generate.rs
-> tests/cli/generation.rs, to match the `generation` command.

The formatting is the owner's in-progress work: blank lines between logical
steps, struct fields and enum variants, the crate's own imports grouped
before the external ones in generation.rs and history.rs, and a blank line
after the consts in external.rs.
The note that a package has no `Services` / `serve` / `connect` linked to a
page chosen by matching the language's name. It now links to the page the
generator names for `Topic::Connections`: a built-in generator's `docs`
table, or the `docs` of the `LanguageInfo` an external generator's
description offers for the target's language. A generator that names none
gets the note without a link.

The `hostile` fixture generator gets `docs` and `plain` modes, which
generate a file with and without a connections page.
@Kinflou
Kinflou marked this pull request as ready for review November 13, 2026 01:09
@Kinflou
Kinflou merged commit f219d80 into main Nov 13, 2026
13 checks passed
@Kinflou
Kinflou deleted the cli/generator-docs-links branch November 13, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant