Repository navigation
Take each generator's docs link from the generator (generation#137 step 1) - #155
Merged
Merged
Conversation
comline-core 35ab4b8 -> 263e583; comline-codegen, comline-doc-markdown and comline-doc-html -> generation 3ad2c79; comline-codegen-rust and comline-codegen-typescript to the heads that pin them. The test generator fixtures pin the same revs. core's changelog now takes the encodings each version sees alongside its schemas and config, so `doc` carries each version's stored configs (own and its dependencies') and reads the encodings from them.
…matting commands/generate.rs -> commands/generation.rs and tests/cli/generate.rs -> tests/cli/generation.rs, to match the `generation` command. The formatting is the owner's in-progress work: blank lines between logical steps, struct fields and enum variants, the crate's own imports grouped before the external ones in generation.rs and history.rs, and a blank line after the consts in external.rs.
The note that a package has no `Services` / `serve` / `connect` linked to a page chosen by matching the language's name. It now links to the page the generator names for `Topic::Connections`: a built-in generator's `docs` table, or the `docs` of the `LanguageInfo` an external generator's description offers for the target's language. A generator that names none gets the note without a link. The `hostile` fixture generator gets `docs` and `plain` modes, which generate a file with and without a connections page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage 3 of ComlineProject/generation#137 step 1: the CLI takes the per-language docs link from the generator instead of hardcoding it.
Services/serve/connect(note_no_connection_protocols) no longer matches on the language name. It links to the page the generator names forTopic::Connections: a built-in generator'sdocstable, or thedocsof theLanguageInfoan external generator's description offers for the target's language. A generator without the topic gets no link. The note's wording is unchanged.comline-core35ab4b8->263e583;comline-codegen,comline-doc-markdown,comline-doc-html-> generation3ad2c79;comline-codegen-rust->3497635;comline-codegen-typescript->20bad45. The test generator fixtures pin the same revs. These point at heads of the open generation#139, comline-rust#123 and comline-typescript#163, which merge with merge commits.Cargo.lockmoves only comline-* git crates.comline doc: core'schangelognow takes the encodings each version sees, sodoccarries each version's stored configs (own and dependencies') and reads them from there.commands/generate.rsis renamedcommands/generation.rs(andtests/cli/generate.rs->generation.rs), to match the command.generation.rsandhistory.rs; a blank line after the consts inexternal.rs.connectionsdoc shows it, and one without gets none (thehostilefixture gainsdocsandplainmodes).