Skip to content

Framing facts and titles in notes; a store in another IR format is refused (generation#137 step 2, core#269) - #156

Merged
Kinflou merged 6 commits into
mainfrom
cli/framing-facts-and-store
Nov 13, 2026
Merged

Kinflou merged 6 commits into
mainfrom
cli/framing-facts-and-store

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 13, 2026 •

Copy link
Copy Markdown
Member

Step 2 of ComlineProject/generation#137, and the CLI side of core#269. Folds in the IR-migration WIP from deps/core-07d86da.

Pins (three commits, in this order)

  • comline-core e2d68a5
  • comline-codegen, comline-doc-markdown, comline-doc-html at 8e7dca8, a commit on the open generation#140 (not its newer head); this rev is not on main yet
  • comline-codegen-rust 3e6864d (head of the open comline-rust#124), comline-codegen-typescript b5fc243 (head of the open comline-typescript#164)
  • the same revs in tests/fixtures/generators/Cargo.toml; comline-runtime-conformance is unchanged
  • Nothing needed fixing to build. Only comline-* git crates moved in the lock files (comline-catalog 0.10.0 to 0.11.0 comes with core).

Store in another IR format (from deps/core-07d86da, f1dba37)
CliError::StoreFormat becomes CliError::Store(StoreError) with core's message (exit code 2); error::from_core maps a core StoreError to it. history::ensure_readable uses core's ensure_compatible_store. build and release refuse such a store instead of rebuilding it, and nothing deletes it. The WIP's local [patch] block is dropped. A config an older build doesn't store (core's unseen) now prints one line each under "Configs not compared" in build, release and diff, and counts toward has_changes (changes::render_unseen, which the WIP called but never defined). Every error now prints its diagnostic help after the message, which shows the three existing helps: NotAProject, Store (pointing to comline reset) and ConfirmationRequired. tests/cli/store_stamp.rs now expects core's message and a refused build.

Messages

  • The "no package Services / serve / connect" note and the async = true warning name each framing in use by framing_title with a reason from why_lockstep, instead of hardcoded JSON-RPC / datagram text.
  • inspect shows "{framing title}'s format" for a format a framing implies.

… pins

comline-core -> e2d68a5, comline-codegen/doc-markdown/doc-html -> 8e7dca8
(a commit on the open generation#140), comline-codegen-rust -> 3e6864d
(comline-rust#124), comline-codegen-typescript -> b5fc243
(comline-typescript#164); the same revs in tests/fixtures/generators.
Nothing needed fixing to build.
…#269)

Adapts the CLI to core's ensure_compatible_store: a .comline/ stamped with
another IR format, no stamp but history, or an unreadable or invalid stamp
is refused by every command, build and release included, with core's own
message (it says nothing was changed). CliError::StoreFormat becomes
CliError::Store(StoreError), exit code 2; error::from_core maps a core
StoreError found in an eyre report to it, for build, release and the
facts of the working tree.

From the WIP on deps/core-07d86da (f1dba37), rebased onto main without
its [patch] block (a local cargo checkout path), and without the calls to
changes::render_unseen, which the WIP never defined.

Tests: store_stamp expected the old message and a build that migrated a
wrong stamp; they now expect core's message and a refused build that
changes nothing.
The no-connection note and the async-unused warning no longer hardcode
JSON-RPC and datagram: each framing in use is named by
comline_codegen::connections::framing_title, with a reason from
why_lockstep (frames go one way; frames don't name the protocol and none
is client-provided; a framing of the package's own). inspect names the
framing a format is implied by the same way ("JSON-RPC's format"
comes from the title, not from the text).
Spec 0.11 has every framing profile state `protocol`, so the `lines`
fixture framing does (`unnamed`: its requests carry no protocol), and
`comline conformance` proves it with the runtime's conformance at 8f8c0cb
(runtime#123), which knows the fact. comline-reference follows to the same rev.
build, diff and release print one line per unseen config: a config an
older build doesn't store counts as changed (at least a patch), and
`comline build` stores it from now on. build also counts it as a change
to report, as the bump already does.
main printed only the message and its causes, so no
#[diagnostic(help(...))] was ever shown. It now prints the help last, as
`help: ...` under --plain (a cyan `help` otherwise), always, like the error.
@Kinflou
Kinflou marked this pull request as ready for review November 13, 2026 03:24
@Kinflou
Kinflou merged commit 684a4f8 into main Nov 13, 2026
13 checks passed
@Kinflou
Kinflou deleted the cli/framing-facts-and-store branch November 13, 2026 03:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant