Skip to content

Render generation's checks from comline-codegen (generation#137 step 3) - #158

Merged
Kinflou merged 2 commits into
mainfrom
cli/generation-diagnostics
Nov 13, 2026
Merged

Kinflou merged 2 commits into
mainfrom
cli/generation-diagnostics

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 13, 2026

Copy link
Copy Markdown
Member

Step 3 of ComlineProject/generation#137, CLI side.

comline generation now shows what comline_codegen::checks::generation returns instead of the CLI's own warn_ignored, warn_async_unused, warn_no_package_connection, note_no_connection_protocols, framings_in_use and lockstep_description (removed). Each diagnostic is rendered by severity: warning with ui::warn, info with ui::note, error as a generation-stopping miette error. The language prefix is put back in front of each message (`{language}`:, or `{language}` ignores for an ignored feature). comline build's JSON-RPC clash uses checks::method_name_clashes, still reported as every target: {message}.

The printed output is unchanged: the existing tests pass as they are, and comline generation / comline build stderr was identical before and after for every code (ignored feature, async unused, no package connection, no connection protocols, name clash). Each diagnostic's unit is not shown yet; nothing drops it before the final render.

Pins (all open heads, merged later with merge commits): generation#142 (05771e0), comline-rust#126 (df91e2e), comline-typescript#167 (8d829be), plus core 868e831. Only comline-* git crates move in both lock files. external tests are left to CI (no wasm32-wasip1 locally).

…ration#137 step 3)

comline-core 868e831; comline-codegen, comline-doc-markdown and
comline-doc-html at generation 05771e0 (generation#142);
comline-codegen-rust df91e2e (comline-rust#126);
comline-codegen-typescript 8d829be (comline-typescript#167).
comline generation shows what comline_codegen::checks::generation returns,
one diagnostic at a time by severity (warning, note, error), with the
language put back in front of each message as before. The JSON-RPC name
clash of comline build is checks::method_name_clashes. The CLI's own
warn_ignored, warn_async_unused, warn_no_package_connection,
note_no_connection_protocols, framings_in_use and lockstep_description are
gone. The output is unchanged.
@Kinflou
Kinflou marked this pull request as ready for review November 13, 2026 13:20
@Kinflou
Kinflou merged commit 22e1544 into main Nov 13, 2026
13 checks passed
@Kinflou
Kinflou deleted the cli/generation-diagnostics branch November 13, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant