Repository navigation
Render generation's checks from comline-codegen (generation#137 step 3) - #158
Merged
Merged
Conversation
…ration#137 step 3) comline-core 868e831; comline-codegen, comline-doc-markdown and comline-doc-html at generation 05771e0 (generation#142); comline-codegen-rust df91e2e (comline-rust#126); comline-codegen-typescript 8d829be (comline-typescript#167).
comline generation shows what comline_codegen::checks::generation returns, one diagnostic at a time by severity (warning, note, error), with the language put back in front of each message as before. The JSON-RPC name clash of comline build is checks::method_name_clashes. The CLI's own warn_ignored, warn_async_unused, warn_no_package_connection, note_no_connection_protocols, framings_in_use and lockstep_description are gone. The output is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 3 of ComlineProject/generation#137, CLI side.
comline generationnow shows whatcomline_codegen::checks::generationreturns instead of the CLI's ownwarn_ignored,warn_async_unused,warn_no_package_connection,note_no_connection_protocols,framings_in_useandlockstep_description(removed). Each diagnostic is rendered by severity: warning withui::warn, info withui::note, error as a generation-stoppingmietteerror. The language prefix is put back in front of each message (`{language}`:, or`{language}` ignoresfor an ignored feature).comline build's JSON-RPC clash useschecks::method_name_clashes, still reported asevery target: {message}.The printed output is unchanged: the existing tests pass as they are, and
comline generation/comline buildstderr was identical before and after for every code (ignored feature, async unused, no package connection, no connection protocols, name clash). Each diagnostic'sunitis not shown yet; nothing drops it before the final render.Pins (all open heads, merged later with merge commits): generation#142 (
05771e0), comline-rust#126 (df91e2e), comline-typescript#167 (8d829be), plus core868e831. Onlycomline-*git crates move in both lock files.externaltests are left to CI (nowasm32-wasip1locally).