Repository navigation
Generation: leave unreached dependency protocols alone (generation#143) - #160
Merged
Merged
Conversation
added 4 commits
November 15, 2026 02:51
…ration at da81b68 (generation#143)
…rustfmt the new tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts generation#146 (merged as da81b688, closes generation#143):
comline generationno longer fails for a package that uses only a dependency's types when the dependency declares adatagram@3+comline@2protocol.comline-codegen,comline-doc-markdownandcomline-doc-htmlat generation da81b688. Core stays at 868e831.GenerateRequest::dependencieswith the package's dependency names: from the compiled context'sdependency_configsfor the working tree, and from the build's stored dependency configs (StoredConfigs, plus the dependencies it vendored without a config) for a built version. A dependency's schemas carry its name as the first/segment of their namespace in both paths (checked by runningcomline generationon a package depending on a local one:greeting/greeting), which is what generation'sis_dependencymatches on.facts_forasksfacts::needed_in(&request), so a package with only a dependency's protocol needs no facts.datagram@3+comline@2protocol runscomline generationfor Rust and TypeScript, from the working tree and from a built version.This PR also carries a separate commit with wording changes: "Resolving dependency '{name}'" in
deps add/deps pin, and "is not supported (available:code,lib)" for an unknown generation mode.Not ready to merge
comline-codegen-rustandcomline-codegen-typescriptare still pinned to revs built against the oldcomline-codegen, so this doesn't compile until they're bumped to revs that use generation da81b688 (and usepackage_connection_among/addressing_in). Those pins follow once their PRs land.