Skip to content

Generation: leave unreached dependency protocols alone (generation#143) - #160

Merged
Kinflou merged 4 commits into
mainfrom
fix/unreached-dependency-protocols
Nov 14, 2026
Merged

Kinflou merged 4 commits into
mainfrom
fix/unreached-dependency-protocols

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 14, 2026

Copy link
Copy Markdown
Member

Adopts generation#146 (merged as da81b688, closes generation#143): comline generation no longer fails for a package that uses only a dependency's types when the dependency declares a datagram@3 + comline@2 protocol.

  • Pins comline-codegen, comline-doc-markdown and comline-doc-html at generation da81b688. Core stays at 868e831.
  • Fills GenerateRequest::dependencies with the package's dependency names: from the compiled context's dependency_configs for the working tree, and from the build's stored dependency configs (StoredConfigs, plus the dependencies it vendored without a config) for a built version. A dependency's schemas carry its name as the first / segment of their namespace in both paths (checked by running comline generation on a package depending on a local one: greeting/greeting), which is what generation's is_dependency matches on.
  • facts_for asks facts::needed_in(&request), so a package with only a dependency's protocol needs no facts.
  • Tests: a package using only the types of a local dependency that declares a datagram@3 + comline@2 protocol runs comline generation for Rust and TypeScript, from the working tree and from a built version.

This PR also carries a separate commit with wording changes: "Resolving dependency '{name}'" in deps add / deps pin, and "is not supported (available: code, lib)" for an unknown generation mode.

Not ready to merge

comline-codegen-rust and comline-codegen-typescript are still pinned to revs built against the old comline-codegen, so this doesn't compile until they're bumped to revs that use generation da81b688 (and use package_connection_among / addressing_in). Those pins follow once their PRs land.

@Kinflou
Kinflou marked this pull request as ready for review November 14, 2026 19:30
@Kinflou
Kinflou merged commit c26b7ec into main Nov 14, 2026
23 checks passed
@Kinflou
Kinflou deleted the fix/unreached-dependency-protocols branch November 14, 2026 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant