Skip to content

Pin the generators at their entry-point revisions - #164

Merged
Kinflou merged 2 commits into
mainfrom
deps/generators-entry-points
Nov 15, 2026
Merged

Kinflou merged 2 commits into
mainfrom
deps/generators-entry-points

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 15, 2026 •

Copy link
Copy Markdown
Member

Pins comline-codegen-rust at dd1c29e6560a0ffd7893c59715b31d43b88c585f (comline-rust#131, includes #132) and comline-codegen-typescript at d377fbf07cf6c0f004e9d5dd4fbd6fa15ea9d0bc (comline-typescript#172). Both pin core 14ce546 and generation e22109e, as the CLI does. Edited the manifest and let Cargo resolve: in Cargo.lock only those two source lines moved.

Test changes

All of them follow the intended change in the generated Rust (Format and CONNECTION_IR_HASH are defined once in connection.rs; the protocol files re-export them with pub use crate::connection::{CONNECTION_IR_HASH, Format};).

  • config_idp_wire_format_reaches_the_rust_generator (tests/cli/generation.rs): pub type Format = comline_runtime::format::Json; is no longer in chat.rs; the assertion reads it from connection.rs. Same assertion, new location.
  • without_a_wire_key_a_protocol_is_on_a_packed_connection: chat.rs now asserts the re-export pub use crate::connection::{CONNECTION_IR_HASH, Format};, and the existing connection.rs section also asserts pub type Format = comline_runtime::format::Packed; (so the packed format stays checked, where it is defined).
  • tests/fixtures/generators/Cargo.{toml,lock}: the fixture generators external::a_native_generator_writes_what_the_builtin_does and a_wasm_... build the "real" generator and compare its output byte for byte with the built-in one, and promise to be at "the same revs the CLI pins". They were still on generation 05771e0 / comline-rust df91e2e (and core 868e831), which had drifted from the CLI's. With the built-in on the new generator the comparison failed, so they now pin generation e22109e and comline-rust dd1c29e. In their lock, the sources that moved are those git sources plus what they pull in transitively (core to 14ce546, specification, a new comline-ir-formats from core).

No assertion was weakened or removed. Other tests that mention generated text (JsonRpcFraming, pub type Format in api.rs) pass unchanged.

CI: all green on ae890c5 (test on stable, beta, nightly, canary, macOS, Windows, arm; lint; the release-target builds).

Kinflou added 2 commits November 15, 2026 08:13
The fixture generators are built at the revs the CLI pins (they had fallen behind), and
the two tests that read the package's wire format from a protocol file read it from
connection.rs, where it is now defined once.
@Kinflou
Kinflou marked this pull request as ready for review November 15, 2026 00:34
@Kinflou
Kinflou merged commit e79092a into main Nov 15, 2026
23 checks passed
@Kinflou
Kinflou deleted the deps/generators-entry-points branch November 15, 2026 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant