Repository navigation
Pin the generators at their entry-point revisions - #164
Merged
Merged
Conversation
added 2 commits
November 15, 2026 08:13
…9e, comline-typescript d377fbf)
The fixture generators are built at the revs the CLI pins (they had fallen behind), and the two tests that read the package's wire format from a protocol file read it from connection.rs, where it is now defined once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins comline-codegen-rust at
dd1c29e6560a0ffd7893c59715b31d43b88c585f(comline-rust#131, includes #132) and comline-codegen-typescript atd377fbf07cf6c0f004e9d5dd4fbd6fa15ea9d0bc(comline-typescript#172). Both pin core14ce546and generatione22109e, as the CLI does. Edited the manifest and let Cargo resolve: inCargo.lockonly those twosourcelines moved.Test changes
All of them follow the intended change in the generated Rust (
FormatandCONNECTION_IR_HASHare defined once inconnection.rs; the protocol files re-export them withpub use crate::connection::{CONNECTION_IR_HASH, Format};).config_idp_wire_format_reaches_the_rust_generator(tests/cli/generation.rs):pub type Format = comline_runtime::format::Json;is no longer inchat.rs; the assertion reads it fromconnection.rs. Same assertion, new location.without_a_wire_key_a_protocol_is_on_a_packed_connection:chat.rsnow asserts the re-exportpub use crate::connection::{CONNECTION_IR_HASH, Format};, and the existingconnection.rssection also assertspub type Format = comline_runtime::format::Packed;(so the packed format stays checked, where it is defined).tests/fixtures/generators/Cargo.{toml,lock}: the fixture generatorsexternal::a_native_generator_writes_what_the_builtin_doesanda_wasm_...build the "real" generator and compare its output byte for byte with the built-in one, and promise to be at "the same revs the CLI pins". They were still on generation05771e0/ comline-rustdf91e2e(and core868e831), which had drifted from the CLI's. With the built-in on the new generator the comparison failed, so they now pin generatione22109eand comline-rustdd1c29e. In their lock, the sources that moved are those git sources plus what they pull in transitively (core to14ce546, specification, a newcomline-ir-formatsfrom core).No assertion was weakened or removed. Other tests that mention generated text (
JsonRpcFraming,pub type Formatinapi.rs) pass unchanged.CI: all green on
ae890c5(test on stable, beta, nightly, canary, macOS, Windows, arm; lint; the release-target builds).