Repository navigation
Report the comline-core commit in --version - #165
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For ComlineProject/comline-vscode#32: the extension compares the
comline-coreits language server was built with against the one the CLI uses, and warns when they differ. The language server reports its commit (language-server#125); this is the CLI side.comline --versiondidn't say which core it links.What changes
comline --versiongets one more line, in the form its other lines already use:core-rev:is the full 40-hex commit, orunknown.-Vstays the bare version.The commit is the
#<sha>of thecomline-coregit source inCargo.lock, read inbuild.rs(no new dependency). A build that sees no lock (cargo installwithout--locked) falls back to the fullrevinCargo.toml'scomline-coreline, then tounknown.build.rsnow also reruns whenCargo.tomlorCargo.lockchange, so a bump to the pin is picked up.Tests
global::version_reports_the_core_rev_it_links:--versionhas acore-rev:line of 40 hex, and it is the revCargo.tomlpins.CI
Tests run in CI.