Repository navigation
chore: enable comline-core's deps feature (core#6) - #31
Merged
Merged
Conversation
comline-core -> ed584ae with features = ["deps"], so `comline build`/`check`
actually resolve and vendor cross-package `dependencies = {...}` (core#6,
core#50). This alone diamond-mismatched against comline-codegen(-rust/
-typescript), which each still pinned the old comline-core independently —
fixed by bumping all three to revs that share the new comline-core:
- comline-codegen -> generation's chore/bump-core-deps-resolution branch tip
(0f8dfcd), now merged as part of ComlineProject/generation#21.
- comline-codegen-rust -> ComlineProject/comline-rust#12's merge (7d56cef).
- comline-codegen-typescript -> ComlineProject/comline-typescript#10's merge
(9af8674).
Completes the cascade: core#50 -> generation#21 -> comline-rust#12 +
comline-typescript#10 -> here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enables
comline-core's new opt-in dependency-resolution feature (core#6,core#50) for the CLI, so
comline build/checkactually resolve andvendor cross-package
dependencies = {...}into CAS.This is the last step of a 5-repo rev-bump cascade, needed because
comline-coreis pinned independently bycli,generation,comline-rustand
comline-typescript, and bumping only one at a time creates a diamond:two incompatible
comline-coreinstances in the build graph.Order: core#50 (merged) -> generation#21 (merged) -> comline-rust#12 +
comline-typescript#10 (merged) -> this PR, which now pins all four
comline-core-touching deps (comline-core,comline-codegen,comline-codegen-rust,comline-codegen-typescript) to revs that agree onone
comline-core.Verified:
cargo build --verboseandcargo test --verboseboth clean(44 tests passing, including the full CLI integration suite).