Skip to content

chore: enable comline-core's deps feature (core#6) - #31

Merged
Kinflou merged 1 commit into
mainfrom
chore/enable-dependency-resolution
Sep 30, 2026
Merged

Kinflou merged 1 commit into
mainfrom
chore/enable-dependency-resolution

Conversation

@Kinflou

@Kinflou Kinflou commented Sep 30, 2026

Copy link
Copy Markdown
Member

Enables comline-core's new opt-in dependency-resolution feature (core#6,
core#50) for the CLI, so comline build/check actually resolve and
vendor cross-package dependencies = {...} into CAS.

This is the last step of a 5-repo rev-bump cascade, needed because
comline-core is pinned independently by cli, generation, comline-rust
and comline-typescript, and bumping only one at a time creates a diamond:
two incompatible comline-core instances in the build graph.

Order: core#50 (merged) -> generation#21 (merged) -> comline-rust#12 +
comline-typescript#10 (merged) -> this PR, which now pins all four
comline-core-touching deps (comline-core, comline-codegen,
comline-codegen-rust, comline-codegen-typescript) to revs that agree on
one comline-core.

Verified: cargo build --verbose and cargo test --verbose both clean
(44 tests passing, including the full CLI integration suite).

comline-core -> ed584ae with features = ["deps"], so `comline build`/`check`
actually resolve and vendor cross-package `dependencies = {...}` (core#6,
core#50). This alone diamond-mismatched against comline-codegen(-rust/
-typescript), which each still pinned the old comline-core independently —
fixed by bumping all three to revs that share the new comline-core:

- comline-codegen -> generation's chore/bump-core-deps-resolution branch tip
  (0f8dfcd), now merged as part of ComlineProject/generation#21.
- comline-codegen-rust -> ComlineProject/comline-rust#12's merge (7d56cef).
- comline-codegen-typescript -> ComlineProject/comline-typescript#10's merge
  (9af8674).

Completes the cascade: core#50 -> generation#21 -> comline-rust#12 +
comline-typescript#10 -> here.
@Kinflou
Kinflou merged commit 95821ca into main Sep 30, 2026
2 checks passed
@Kinflou
Kinflou deleted the chore/enable-dependency-resolution branch September 30, 2026 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant