Repository navigation
chore: bump comline-core/codegen pins for type aliases - #33
Merged
Merged
Conversation
comline-core gained a transparent `type` alias declaration (ComlineProject/core#54, type UserId = u64 - fully erased before freezing, no codegen-visible change). Bumps comline-codegen (ComlineProject/generation#24+#25), comline-codegen-rust (ComlineProject/comline-rust#15), and comline-codegen-typescript (ComlineProject/comline-typescript#13) in lockstep, per the dependency order each of those needed (generation first, since the two per-language codegens consume its types). Verified end-to-end against a real package using a local alias, a cross-file alias (via `use`), and an alias-of-alias array, through `comline check`/`build`/`generate` - generated Rust never mentions the alias name, only the resolved primitive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comline-coregained a transparenttypealias declaration (feat: transparent type alias for the IDL core#54,type UserId = u64— fully erased before freezing, no codegen-visible change).comline-codegen(chore: bump comline-core to pick up type aliases generation#24, test: end-to-end handshake — driver uses ChatClient::connect / Dispatcher::serve #25),comline-codegen-rust(chore: bump comline-core and comline-codegen for type aliases comline-rust#15), andcomline-codegen-typescript(chore: bump comline-core and comline-codegen for type aliases comline-typescript#13) in lockstep, in the dependency order each needed (generation first — the two per-language codegens consume its types, so they can't bump ahead of it).comline generate/checkfailed to parse any.idsfile usingtypeat all (UnexpectedToken("type")), since this crate's pins hadn't moved past the pre-alias core rev.Test plan
cargo build --verbose/cargo test --verbose— clean, single consistentcomline-coreinstance in the graph (46 tests passing)use), an alias-of-alias array, all through realcomline check/generate— generated Rust never mentions the alias name, only the resolved primitive