Repository navigation
chore: bump comline-core and the codegen crates for unresolved-import rejection - #38
Merged
Merged
Conversation
… rejection Moves comline-core to a4e810f, so `comline check` / `build` reject a `use` that matches nothing (core#59, with a "did you mean"), and also pick up core#58's `package::` rename and self/parent resolution fix and core#57's vocabulary module. comline-codegen, comline-codegen-rust and comline-codegen-typescript move together to revs on the same core (generation#30, comline-rust#18, comline-typescript#16). comline-codegen is pinned to the generation commit the two generators pin, not generation#30's later commit, so the tree keeps one comline-codegen.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moves
comline-coretoa4e810f, socomline checkandcomline buildreject ausethat matches nothing (core#59). It also picks up core#58 (crate::is nowpackage::;self::/parent::/package::imports actually resolve) and core#57's vocabulary module.The three codegen crates move with it, to revisions on the same core: generation#30, comline-rust#18, comline-typescript#16.
comline-codegenis pinned to7f094cf, the generation commit the two generators pin, not generation#30's later commit, so the tree keeps a singlecomline-codegen. All four PRs are green and can merge in any order.Same throwaway package,
src/chat.ids=use typse::User(a typo fortypes):comline checkmainCheck passed, exit 0Unresolved import/no schema in this package or its dependencies matches 'typse::User' - did you mean 'types'?With the import fixed to
use types::User, it passes again.None of this repo's fixtures contain a
use, so no test changes are needed.Test plan
cargo build: clean, with onecomline_corein the treecargo test: 49 passcomline checkrun above