Skip to content

chore: bump comline-core and the codegen crates for unresolved-import rejection - #38

Merged
Kinflou merged 1 commit into
mainfrom
chore/bump-core-unresolved-imports
Oct 4, 2026
Merged

Kinflou merged 1 commit into
mainfrom
chore/bump-core-unresolved-imports

Conversation

@Kinflou

@Kinflou Kinflou commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

Summary

Moves comline-core to a4e810f, so comline check and comline build reject a use that matches nothing (core#59). It also picks up core#58 (crate:: is now package::; self::/parent::/package:: imports actually resolve) and core#57's vocabulary module.

The three codegen crates move with it, to revisions on the same core: generation#30, comline-rust#18, comline-typescript#16. comline-codegen is pinned to 7f094cf, the generation commit the two generators pin, not generation#30's later commit, so the tree keeps a single comline-codegen. All four PRs are green and can merge in any order.

Same throwaway package, src/chat.ids = use typse::User (a typo for types):

comline check
main Check passed, exit 0
this branch exit 1, rendered on the line: Unresolved import / no schema in this package or its dependencies matches 'typse::User' - did you mean 'types'?

With the import fixed to use types::User, it passes again.

None of this repo's fixtures contain a use, so no test changes are needed.

Test plan

  • cargo build: clean, with one comline_core in the tree
  • cargo test: 49 pass
  • The before/after comline check run above

… rejection

Moves comline-core to a4e810f, so `comline check` / `build` reject a
`use` that matches nothing (core#59, with a "did you mean"), and also
pick up core#58's `package::` rename and self/parent resolution fix and
core#57's vocabulary module.

comline-codegen, comline-codegen-rust and comline-codegen-typescript move
together to revs on the same core (generation#30, comline-rust#18,
comline-typescript#16). comline-codegen is pinned to the generation commit
the two generators pin, not generation#30's later commit, so the tree keeps
one comline-codegen.
@Kinflou
Kinflou merged commit f6bb54f into main Oct 4, 2026
2 checks passed
@Kinflou
Kinflou deleted the chore/bump-core-unresolved-imports branch October 4, 2026 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant