Skip to content

Bump core for relative glob and multi imports (core#61) - #39

Merged
Kinflou merged 1 commit into
mainfrom
chore/bump-core-relative-imports
Oct 4, 2026
Merged

Kinflou merged 1 commit into
mainfrom
chore/bump-core-relative-imports

Conversation

@Kinflou

@Kinflou Kinflou commented Oct 4, 2026 •

Copy link
Copy Markdown
Member

Summary

Since core#59, comline check rejected two valid imports:

use parent::common::*               // no schema in this package or its dependencies matches 'parent::common'
use parent::common::{Error, Other}  // same, and this one compiled before core#59

core#61 resolves self / parent / package in both forms. This moves the CLI to it.

Pins comline-core to d6d4617 and moves the other crates with it, so the build keeps one comline-core:

  • comline-codegen: generation#31's first commit, the rev the generators pin;
  • comline-codegen-rust: comline-rust#19;
  • comline-codegen-typescript: comline-typescript#17.

Merge after (or together with) core#61, generation#31, comline-rust#19 and comline-typescript#17.

Test plan

  • cargo test: all suites pass.
  • cargo clippy --all-targets -- -D warnings and cargo fmt --check: clean.
  • Cargo.lock: regenerated by cargo, only the four pins change, and comline-core resolves once.
  • comline check:
    • a package using use parent::common::Error, use parent::common, ::* and ::{Error, Other} passes (it failed on the last two before);
    • use typse::User and use types::Usr are still rejected, with the same messages as before.

`use parent::common::*` and `use parent::common::{A, B}` failed
`comline check` with "no schema in this package or its dependencies
matches 'parent::common'" (the multi form compiled before core#59).
core#61 resolves self/parent/package in both forms.

Pins comline-core to d6d4617, with comline-codegen, comline-codegen-rust
and comline-codegen-typescript moved together so the build keeps one
comline-core: generation#31's first commit (the rev the generators pin),
comline-rust#19 and comline-typescript#17.
@Kinflou
Kinflou merged commit 67e70b5 into main Oct 4, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant