Repository navigation
Bump core for relative glob and multi imports (core#61) - #39
Merged
Merged
Conversation
`use parent::common::*` and `use parent::common::{A, B}` failed
`comline check` with "no schema in this package or its dependencies
matches 'parent::common'" (the multi form compiled before core#59).
core#61 resolves self/parent/package in both forms.
Pins comline-core to d6d4617, with comline-codegen, comline-codegen-rust
and comline-codegen-typescript moved together so the build keeps one
comline-core: generation#31's first commit (the rev the generators pin),
comline-rust#19 and comline-typescript#17.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Since core#59,
comline checkrejected two valid imports:core#61 resolves
self/parent/packagein both forms. This moves the CLI to it.Pins comline-core to
d6d4617and moves the other crates with it, so the build keeps one comline-core:Merge after (or together with) core#61, generation#31, comline-rust#19 and comline-typescript#17.
Test plan
cargo test: all suites pass.cargo clippy --all-targets -- -D warningsandcargo fmt --check: clean.Cargo.lock: regenerated by cargo, only the four pins change, and comline-core resolves once.comline check:use parent::common::Error,use parent::common,::*and::{Error, Other}passes (it failed on the last two before);use typse::Useranduse types::Usrare still rejected, with the same messages as before.