Repository navigation
Bump core for the embedded std (core#62) - #42
Merged
Merged
Conversation
`use std::…` now resolves against the standard library embedded in core: `comline check` / `build` / `generate` merge the std schemas a package imports (`std::http`, `std::validators`), check std imports like any other, and generate the std schemas used alongside the package's own. Pins comline-core to 1ec7ad1, with comline-codegen, comline-codegen-rust and comline-codegen-typescript moved together so the build keeps one comline-core: generation#32's first commit (the rev the generators pin), comline-rust#20 and comline-typescript#18. Adds an end-to-end check test: a package using std types and the std validator passes with no warnings, and a std typo is rejected with its suggestion.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes std usable from the CLI. With core#62,
use std::…resolves against the standard library embedded in core:comline check,buildandgeneratemerge in the std schemas a package imports (std::http,std::validators);std has no schema matching 'std::htp::Request' - did you mean 'std::http'?;generated/rust/std/http.rs.Pins comline-core to
1ec7ad1and moves the other crates with it, so the build keeps one comline-core:Merge after (or together with) core#62, generation#32, comline-rust#20 and comline-typescript#18.
Test plan
std::httptypes and thestd::validators::StringBoundsvalidator passescheckwith no warnings, and a std typo is rejected with its suggestion.cargo test,cargo clippy --all-targets -- -D warningsandcargo fmt --checkall clean.Cargo.lock: regenerated by cargo. It changes the four pins and addscomline-core-stdlibfrom core's git source; comline-core resolves once.buildfreezes 0.0.1, andgeneratewritesapi.rs,std/http.rsandstd/validators.rs.