Repository navigation
chore: bump comline-core and comline-codegen* for settings hover - #49
Merged
Merged
Conversation
Step 4 (final) of the comline-core pin cascade - bumps to core's current master (settings hover + enforcement, ComlineProject/core#73), generation's post-step-1-merge codegen SHA (generation#38, matching comline-rust#27/comline-typescript#24's own pin so the CLI's build graph has one comline-codegen), and comline-rust/comline-typescript's own post-merge SHAs. Fixes the real symptom this cascade started from: `comline generate` panicking with "Assignment 'settings' is not a valid assignment" on any package with a `settings` key in config.idp, since the CLI's core pin predated the settings feature entirely.
Kinflou
force-pushed
the
chore/bump-core-settings-hover
branch
from
October 6, 2026 15:10
c647e8c to
a55a9c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Step 4 (final) of the comline-core pin cascade. Bumps to core's current master (ComlineProject/core#73), generation's post-step-1-merge codegen SHA (generation#38, matching comline-rust#27/comline-typescript#24's own pin so the build graph has one
comline-codegen), and comline-rust/comline-typescript's post-merge SHAs.Fixes the real symptom this cascade started from:
comline generatepanicking withAssignment 'settings' is not a valid assignmenton any package whoseconfig.idphas asettingskey — the CLI's core pin predated the settings feature entirely (3c9d299, before ComlineProject/core#50 even).Test plan
cargo test— 52 CLI integration tests + 13 lib tests, all pass, including a realend_to_end::a_generated_protocol_crate_runs_a_real_round_trip