Skip to content

chore: bump comline-core and comline-codegen* for settings hover - #49

Merged
Kinflou merged 1 commit into
mainfrom
chore/bump-core-settings-hover
Oct 6, 2026
Merged

Kinflou merged 1 commit into
mainfrom
chore/bump-core-settings-hover

Conversation

@Kinflou

@Kinflou Kinflou commented Oct 6, 2026

Copy link
Copy Markdown
Member

Summary

Step 4 (final) of the comline-core pin cascade. Bumps to core's current master (ComlineProject/core#73), generation's post-step-1-merge codegen SHA (generation#38, matching comline-rust#27/comline-typescript#24's own pin so the build graph has one comline-codegen), and comline-rust/comline-typescript's post-merge SHAs.

Fixes the real symptom this cascade started from: comline generate panicking with Assignment 'settings' is not a valid assignment on any package whose config.idp has a settings key — the CLI's core pin predated the settings feature entirely (3c9d299, before ComlineProject/core#50 even).

Test plan

  • cargo test — 52 CLI integration tests + 13 lib tests, all pass, including a real end_to_end::a_generated_protocol_crate_runs_a_real_round_trip

Step 4 (final) of the comline-core pin cascade - bumps to core's
current master (settings hover + enforcement, ComlineProject/core#73),
generation's post-step-1-merge codegen SHA (generation#38, matching
comline-rust#27/comline-typescript#24's own pin so the CLI's build graph
has one comline-codegen), and comline-rust/comline-typescript's own
post-merge SHAs. Fixes the real symptom this cascade started from:
`comline generate` panicking with "Assignment 'settings' is not a valid
assignment" on any package with a `settings` key in config.idp, since
the CLI's core pin predated the settings feature entirely.
@Kinflou
Kinflou force-pushed the chore/bump-core-settings-hover branch from c647e8c to a55a9c0 Compare October 6, 2026 15:10
@Kinflou
Kinflou merged commit 10d38c7 into main Oct 6, 2026
4 checks passed
@Kinflou
Kinflou deleted the chore/bump-core-settings-hover branch October 6, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant