Skip to content

feat: surface non-fatal warnings in check/generate/build - #53

Merged
Kinflou merged 1 commit into
mainfrom
feat/surface-deprecation-warnings
Oct 11, 2026
Merged

Kinflou merged 1 commit into
mainfrom
feat/surface-deprecation-warnings

Conversation

@Kinflou

@Kinflou Kinflou commented Oct 11, 2026

Copy link
Copy Markdown
Member

Summary

Last step of the cascade for core#80's deprecation-usage warnings. Depends on generation#41, comline-rust#31 + comline-rust#32, and comline-typescript#26 - all must merge first, in that order.

  • Bumps comline-core/comline-codegen/comline-codegen-rust/comline-codegen-typescript to the cascade's final revs.
  • check, generate, and build each call the new ProjectContext::rendered_warnings() and print any with ui::warn, after a successful compile and before their own success message.

This is the piece that makes a @deprecated struct's usage visible from the terminal, not just the editor (language-server#48 already handles that side).

Test plan

  • cargo test --all-features: all green (57 + 17, 0 failures) - this also incidentally caught and fixed an unrelated pre-existing bug once pointed at comline-rust's real merged history (comline-rust#32).
  • cargo clippy --all-targets --all-features: clean.
  • Real end-to-end against a scratch project with @deprecated = "use NewAuthor instead" on a referenced struct: check, generate, and build all render the warning (code validation::deprecated-type-usage, correct span/context) and exit 0 - confirmed a warning genuinely doesn't fail the build. A project with nothing deprecated prints nothing extra.

Bumps the comline-core + comline-codegen + comline-codegen-rust +
comline-codegen-typescript pins to the end of the cascade needed for
core#80's new ProjectContext::rendered_warnings() (deprecation-usage
warnings, the first non-fatal diagnostic in the toolchain). check,
generate, and build each print any accumulated warnings via ui::warn
after a successful compile, before their own success message.

Verified end-to-end against a scratch project with a @deprecated
struct: all three commands render the warning (code, span, context)
and exit 0 - confirming a warning genuinely doesn't fail the build.
@Kinflou
Kinflou merged commit 2ecc609 into main Oct 11, 2026
2 checks passed
@Kinflou
Kinflou deleted the feat/surface-deprecation-warnings branch November 8, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant