Skip to content

chore: bump core and the generators for typed configuration values - #54

Merged
Kinflou merged 2 commits into
mainfrom
chore/bump-core-typed-config-values
Oct 12, 2026
Merged

Kinflou merged 2 commits into
mainfrom
chore/bump-core-typed-config-values

Conversation

@Kinflou

@Kinflou Kinflou commented Oct 12, 2026

Copy link
Copy Markdown
Member

Pin bumps for ComlineProject/core#87 and its cascade. The CLI matches on
no FrozenUnit::Property, so pins only.

One constraint worth recording: comline-codegen must be pinned at the
same generation rev the generator crates pin, not simply at
generation's branch tip. Pinning a later generation commit put two
comline_codegen revs in the graph and register(&mut registry) stopped
type-checking — against two distinct Registry types.

Verified end-to-end

Against a real package built by the pre-bump binary:

  • the .comline/ store is detected as stale (found Some(1), need 2),
    rebuilt, and restamped to 2 rather than misread;
  • @framing = "nonsense" and @timeout_ms = "abc" are now build errors
    (validation::annotation-value-mismatch) — both used to compile clean
    and be silently dropped;
  • a misspelled settings key fails with a suggestion
    (annotations.framing.alowed → annotations.framing.allowed);
  • an unknown top-level settings key still builds, as intended — the
    namespace stays open outside the groups core owns;
  • all five @framing spellings core accepts are accepted here;
  • a misspelled key in a .idp manifest is reported rather than panicking.

The built-in-default fix is visible too: a bad @framing now also draws
settings::forbidden, because annotations.framing.allowed = false
actually applies to packages that write their own settings.

Kinflou added 2 commits October 12, 2026 16:27
core#87 and its cascade. The CLI matches on no `FrozenUnit::Property`,
so this is pins only.

One constraint worth recording: `comline-codegen` must be pinned at the
*same* generation rev the generator crates pin, not simply at
generation's branch tip. Pinning the later conformance commit put two
`comline_codegen` revs in the graph and `register(&mut registry)` stopped
type-checking against two distinct `Registry` types.

Verified end-to-end against a real package built by the pre-bump binary:
the `.comline/` store is detected as stale ("found Some(1), need 2"),
rebuilt, and restamped to 2 rather than misread. The new checks all fire
through the CLI - a bad `@framing` value, `@timeout_ms = "abc"`, and a
misspelled settings key are each reported with a suggestion, while an
unknown *top-level* settings key still builds, as intended. All five
`@framing` spellings core accepts are accepted here too.
core#87 grew four more commits while the language-server half of the
cascade was written - the registry facts the editor needs (which key
pattern segments are placeholders, which keys take a declaration prefix)
and a `Display` for settings values. Every consumer in one build graph
has to pin the same `comline-core` rev or `Registry`-style types stop
matching across crates, so this moves with them.
@Kinflou
Kinflou merged commit d11d624 into main Oct 12, 2026
2 checks passed
@Kinflou
Kinflou deleted the chore/bump-core-typed-config-values branch November 8, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant