Repository navigation
chore: bump core and the generators for typed configuration values - #54
Merged
Merged
Conversation
added 2 commits
October 12, 2026 16:27
core#87 and its cascade. The CLI matches on no `FrozenUnit::Property`,
so this is pins only.
One constraint worth recording: `comline-codegen` must be pinned at the
*same* generation rev the generator crates pin, not simply at
generation's branch tip. Pinning the later conformance commit put two
`comline_codegen` revs in the graph and `register(&mut registry)` stopped
type-checking against two distinct `Registry` types.
Verified end-to-end against a real package built by the pre-bump binary:
the `.comline/` store is detected as stale ("found Some(1), need 2"),
rebuilt, and restamped to 2 rather than misread. The new checks all fire
through the CLI - a bad `@framing` value, `@timeout_ms = "abc"`, and a
misspelled settings key are each reported with a suggestion, while an
unknown *top-level* settings key still builds, as intended. All five
`@framing` spellings core accepts are accepted here too.
core#87 grew four more commits while the language-server half of the cascade was written - the registry facts the editor needs (which key pattern segments are placeholders, which keys take a declaration prefix) and a `Display` for settings values. Every consumer in one build graph has to pin the same `comline-core` rev or `Registry`-style types stop matching across crates, so this moves with them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin bumps for ComlineProject/core#87 and its cascade. The CLI matches on
no
FrozenUnit::Property, so pins only.One constraint worth recording:
comline-codegenmust be pinned at thesame generation rev the generator crates pin, not simply at
generation's branch tip. Pinning a later generation commit put two
comline_codegenrevs in the graph andregister(&mut registry)stoppedtype-checking — against two distinct
Registrytypes.Verified end-to-end
Against a real package built by the pre-bump binary:
.comline/store is detected as stale (found Some(1), need 2),rebuilt, and restamped to
2rather than misread;@framing = "nonsense"and@timeout_ms = "abc"are now build errors(
validation::annotation-value-mismatch) — both used to compile cleanand be silently dropped;
(
annotations.framing.alowed→annotations.framing.allowed);namespace stays open outside the groups core owns;
@framingspellings core accepts are accepted here;.idpmanifest is reported rather than panicking.The built-in-default fix is visible too: a bad
@framingnow also drawssettings::forbidden, becauseannotations.framing.allowed = falseactually applies to packages that write their own settings.