Repository navigation
chore: bump core and the generators for the .idp panic fix - #55
Merged
Merged
Conversation
core#88 converts `.idp` interpretation's panics into returned errors, so
a malformed manifest now prints
error build failed: dependency name 'std' is reserved: ...
instead of a panic message and a backtrace. Verified against the project
that surfaced it.
Hit the documented trap again while doing it: `comline-codegen` must be
pinned at the rev the generator crates pin, and it was still on the
previous generation commit, which put two `comline_codegen` versions in
the graph.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up ComlineProject/core#88. A malformed manifest now prints
instead of a panic message and a backtrace. Verified against the project that surfaced it.
Hit the documented pin trap again on the way:
comline-codegenmust be pinned at the rev the generator crates pin, and it was still on the previous generation commit — which put twocomline_codegenversions in the graph and brokeregister(&mut registry)against two distinctRegistrytypes.Pins: core@4b77d96, generation@bccab5c, comline-rust@07bb355, comline-typescript@5367c73.