Skip to content

chore: point at the TypeScript generator's nested-namespace support - #60

Merged
Kinflou merged 1 commit into
mainfrom
chore/typescript-nested-namespaces
Oct 13, 2026
Merged

Kinflou merged 1 commit into
mainfrom
chore/typescript-nested-namespaces

Conversation

@Kinflou

@Kinflou Kinflou commented Oct 13, 2026

Copy link
Copy Markdown
Member

Picks up comline-typescript#32.

Two gaps there, both of which the CLI surfaces:

  • cross-schema type references were emitted as bare names with no import,
    so any schema using another's types produced TypeScript that could not
    compile — in code mode as well as lib
  • lib mode refused nested namespaces, and std (std/http,
    std/validators) is implicit in every package, so that refusal fired
    always. mode = "lib" was unusable for typescript, which is what
    cli#59 exposed once typescript stopped being silently dropped.

Also rewrites the comment above the three generator pins. It still described
comline-codegen-rust and comline-codegen-typescript as branch tips
"pending those PRs' merge" — stale for several bumps, and all three revs are
now verified merged commits on their repos' default branches. The durable
constraint is the one worth recording: the comline-codegen rev must be
byte-identical to the one the generator crates pin, since Cargo unifies a git
dependency only across identical rev strings and two copies of GenRequest
are two incompatible types.

cargo test --all green (29 + 61), fmt and clippy clean.

comline-typescript#32: cross-schema types are imported rather than emitted
as bare names, and `lib` mode mirrors nested namespaces instead of refusing
them. The refusal fired for every project - `std` is implicit everywhere -
so this is what makes `mode = "lib"` usable for typescript at all.

Also rewrites the comment above these three pins, which still described two
of them as branch tips "pending those PRs' merge" from several bumps ago.
What matters about them isn't which PR they came from, it's that the
`comline-codegen` rev has to be byte-identical to the one the generator
crates pin, so that is what it says now.
@Kinflou
Kinflou merged commit 076e56f into main Oct 13, 2026
2 checks passed
@Kinflou
Kinflou deleted the chore/typescript-nested-namespaces branch October 13, 2026 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant