Repository navigation
chore: point at the TypeScript generator's nested-namespace support - #60
Merged
Merged
Conversation
comline-typescript#32: cross-schema types are imported rather than emitted as bare names, and `lib` mode mirrors nested namespaces instead of refusing them. The refusal fired for every project - `std` is implicit everywhere - so this is what makes `mode = "lib"` usable for typescript at all. Also rewrites the comment above these three pins, which still described two of them as branch tips "pending those PRs' merge" from several bumps ago. What matters about them isn't which PR they came from, it's that the `comline-codegen` rev has to be byte-identical to the one the generator crates pin, so that is what it says now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up comline-typescript#32.
Two gaps there, both of which the CLI surfaces:
import,so any schema using another's types produced TypeScript that could not
compile — in
codemode as well asliblibmode refused nested namespaces, andstd(std/http,std/validators) is implicit in every package, so that refusal firedalways.
mode = "lib"was unusable for typescript, which is whatcli#59 exposed once typescript stopped being silently dropped.
Also rewrites the comment above the three generator pins. It still described
comline-codegen-rustandcomline-codegen-typescriptas branch tips"pending those PRs' merge" — stale for several bumps, and all three revs are
now verified merged commits on their repos' default branches. The durable
constraint is the one worth recording: the
comline-codegenrev must bebyte-identical to the one the generator crates pin, since Cargo unifies a git
dependency only across identical rev strings and two copies of
GenRequestare two incompatible types.
cargo test --allgreen (29 + 61), fmt and clippy clean.