Skip to content

chore: point at the TypeScript generator's external_std support - #62

Merged
Kinflou merged 1 commit into
mainfrom
chore/typescript-external-std
Oct 13, 2026
Merged

Kinflou merged 1 commit into
mainfrom
chore/typescript-external-std

Conversation

@Kinflou

@Kinflou Kinflou commented Oct 13, 2026

Copy link
Copy Markdown
Member

Picks up comline-typescript#33.

external_std now does something for typescript: std's schemas are left out
of the generated package and referenced from @comline/std instead — a
committed, generated npm package, the counterpart of comline_std.

This is what makes [generate] mode = "lib"'s default coherent across
targets. The CLI has defaulted external_std on in lib mode since cli#58,
and typescript quietly ignored it, so a two-target project got rust
referencing comline_std while typescript inlined its own copy of std. Now
both reference their std package, and --no-external-std inlines for both.

No CLI code changes — external_std was already plumbed through
GenRequest; only the generator rev moves. comline-codegen and
comline-core are untouched, so there's no wider cascade.

cargo test --all green (29 + 63), fmt and clippy clean.

comline-typescript#33: `external_std` now does something for typescript -
std's schemas are left out of the generated package and referenced from
`@comline/std` instead, the npm counterpart of `comline_std`.

This is what makes `mode = "lib"`'s default coherent across targets. The CLI
has defaulted `external_std` on in `lib` mode since #58, and until now
typescript quietly ignored it: a two-target project got rust referencing
`comline_std` while typescript inlined its own copy of std.
@Kinflou
Kinflou merged commit 535ec90 into main Oct 13, 2026
2 checks passed
@Kinflou
Kinflou deleted the chore/typescript-external-std branch October 13, 2026 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant