Repository navigation
chore: point at the TypeScript generator's external_std support - #62
Merged
Merged
Conversation
comline-typescript#33: `external_std` now does something for typescript - std's schemas are left out of the generated package and referenced from `@comline/std` instead, the npm counterpart of `comline_std`. This is what makes `mode = "lib"`'s default coherent across targets. The CLI has defaulted `external_std` on in `lib` mode since #58, and until now typescript quietly ignored it: a two-target project got rust referencing `comline_std` while typescript inlined its own copy of std.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up comline-typescript#33.
external_stdnow does something for typescript: std's schemas are left outof the generated package and referenced from
@comline/stdinstead — acommitted, generated npm package, the counterpart of
comline_std.This is what makes
[generate] mode = "lib"'s default coherent acrosstargets. The CLI has defaulted
external_stdon inlibmode since cli#58,and typescript quietly ignored it, so a two-target project got rust
referencing
comline_stdwhile typescript inlined its own copy of std. Nowboth reference their std package, and
--no-external-stdinlines for both.No CLI code changes —
external_stdwas already plumbed throughGenRequest; only the generator rev moves.comline-codegenandcomline-coreare untouched, so there's no wider cascade.cargo test --allgreen (29 + 63), fmt and clippy clean.