Repository navigation
chore: point at the aliased-import fix in the Rust generator - #63
Merged
Merged
Conversation
comline-rust#39: `use shared::Shared as Aliased` emitted `crate::shared::Aliased`, where `shared` exports only `Shared` - well-formed Rust that names nothing (`error[E0425]`). Any project using an aliased cross-schema import got output that wouldn't build. Found by making the conformance corpus multi-schema (generation#47), which until then held one schema per fixture and so couldn't express a reference crossing schemas at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up comline-rust#39.
use shared::Shared as Aliasedemittedcrate::shared::Aliased, butsharedexports only
Shared— well-formed Rust naming nothing:Any project with an aliased cross-schema import was getting Rust output that
wouldn't build, in both
codeandlibmode. This is the first release ofthe CLI that doesn't.
Found by making the conformance corpus multi-schema
(generation#47) — a
fixture held one schema until then, so the corpus couldn't express a reference
that crosses schemas at all. It surfaced on the corpus's first run.
No CLI code changes; only the generator rev.
comline-codegenandcomline-coreare untouched, so no wider cascade.cargo test --allgreen (29 + 63), fmt clean.