Skip to content

chore: point at the kernel-based generators - #64

Merged
Kinflou merged 1 commit into
mainfrom
chore/bump-kernel-generators
Oct 13, 2026
Merged

Kinflou merged 1 commit into
mainfrom
chore/bump-kernel-generators

Conversation

@Kinflou

@Kinflou Kinflou commented Oct 13, 2026

Copy link
Copy Markdown
Member

Both generators now resolve cross-schema references through the shared
kernel in comline-codegen (comline-rust#40, comline-typescript#34, on
top of generation#48). Output is unchanged - this is the pin bump that
carries it into the CLI.

All three revs move together, as the comment above them says they must:
comline-codegen goes to the kernel merge, and both generator crates
pin that exact rev, so Cargo unifies them into one comline-codegen.
Leaving the first behind would have given the tree two copies of
GenRequest - incompatible types with the same name. Verified with
cargo tree, not assumed.

Checked end to end on a two-target project rather than only through the
suite:

  • a glob use std::http::* resolves for both targets -
    crate::std::http::Request and import type { Request } from "./std/http.js". That one matters: comline-typescript#34 deleted the
    TypeScript generator's own glob expansion on the grounds that core
    already emits the leaves, and this is that claim holding on a real
    project instead of a hand-built fixture.
  • lib mode for both, where external_std defaults on: std referenced
    (comline_std::http::Request, @comline/std/http) rather than
    inlined, with the dependency declared in Cargo.toml and
    package.json.

Both generators now resolve cross-schema references through the shared
kernel in `comline-codegen` (comline-rust#40, comline-typescript#34, on
top of generation#48). Output is unchanged - this is the pin bump that
carries it into the CLI.

All three revs move together, as the comment above them says they must:
`comline-codegen` goes to the kernel merge, and both generator crates
pin that exact rev, so Cargo unifies them into one `comline-codegen`.
Leaving the first behind would have given the tree two copies of
`GenRequest` - incompatible types with the same name. Verified with
`cargo tree`, not assumed.

Checked end to end on a two-target project rather than only through the
suite:

- a glob `use std::http::*` resolves for **both** targets -
  `crate::std::http::Request` and `import type { Request } from
  "./std/http.js"`. That one matters: comline-typescript#34 deleted the
  TypeScript generator's own glob expansion on the grounds that core
  already emits the leaves, and this is that claim holding on a real
  project instead of a hand-built fixture.
- `lib` mode for both, where `external_std` defaults on: std referenced
  (`comline_std::http::Request`, `@comline/std/http`) rather than
  inlined, with the dependency declared in `Cargo.toml` and
  `package.json`.
@Kinflou
Kinflou merged commit d4a79f5 into main Oct 13, 2026
2 checks passed
@Kinflou
Kinflou deleted the chore/bump-kernel-generators branch October 13, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant