Repository navigation
chore: point at the kernel-based generators - #64
Merged
Merged
Conversation
Both generators now resolve cross-schema references through the shared
kernel in `comline-codegen` (comline-rust#40, comline-typescript#34, on
top of generation#48). Output is unchanged - this is the pin bump that
carries it into the CLI.
All three revs move together, as the comment above them says they must:
`comline-codegen` goes to the kernel merge, and both generator crates
pin that exact rev, so Cargo unifies them into one `comline-codegen`.
Leaving the first behind would have given the tree two copies of
`GenRequest` - incompatible types with the same name. Verified with
`cargo tree`, not assumed.
Checked end to end on a two-target project rather than only through the
suite:
- a glob `use std::http::*` resolves for **both** targets -
`crate::std::http::Request` and `import type { Request } from
"./std/http.js"`. That one matters: comline-typescript#34 deleted the
TypeScript generator's own glob expansion on the grounds that core
already emits the leaves, and this is that claim holding on a real
project instead of a hand-built fixture.
- `lib` mode for both, where `external_std` defaults on: std referenced
(`comline_std::http::Request`, `@comline/std/http`) rather than
inlined, with the dependency declared in `Cargo.toml` and
`package.json`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both generators now resolve cross-schema references through the shared
kernel in
comline-codegen(comline-rust#40, comline-typescript#34, ontop of generation#48). Output is unchanged - this is the pin bump that
carries it into the CLI.
All three revs move together, as the comment above them says they must:
comline-codegengoes to the kernel merge, and both generator cratespin that exact rev, so Cargo unifies them into one
comline-codegen.Leaving the first behind would have given the tree two copies of
GenRequest- incompatible types with the same name. Verified withcargo tree, not assumed.Checked end to end on a two-target project rather than only through the
suite:
use std::http::*resolves for both targets -crate::std::http::Requestandimport type { Request } from "./std/http.js". That one matters: comline-typescript#34 deleted theTypeScript generator's own glob expansion on the grounds that core
already emits the leaves, and this is that claim holding on a real
project instead of a hand-built fixture.
libmode for both, whereexternal_stddefaults on: std referenced(
comline_std::http::Request,@comline/std/http) rather thaninlined, with the dependency declared in
Cargo.tomlandpackage.json.