Skip to content

chore: bump core and both generators for declared types and constants - #65

Merged
Kinflou merged 1 commit into
mainfrom
chore/bump-core-declared-types
Oct 13, 2026
Merged

Kinflou merged 1 commit into
mainfrom
chore/bump-core-declared-types

Conversation

@Kinflou

@Kinflou Kinflou commented Oct 13, 2026

Copy link
Copy Markdown
Member

Carries core#92 and the two generator changes that build on it into the
CLI. All four revs move together so Cargo unifies them - verified with
cargo tree, one comline-core and one comline-codegen in the graph.

Checked end to end on a two-target project, since the bugs involved were
all "generated output is wrong" rather than anything a unit test sees:

  • retries: u8 = 5 now generates pub retries: u8, not pub retries: u64
  • name: string = "x" now generates pub name: String, not pub name: ,
    which did not parse
  • const DEBUG: bool = true generates true - it used to freeze as
    false in the IR regardless of what was written
  • constants are emitted at all, in both targets, docstring included
  • a file with nothing to derive no longer carries an unused use serde

core#92 is the interesting one: no generator change was needed for the
first three, because both generators already render a primitive's own
name. Fixing the IR fixed the output.

Carries core#92 and the two generator changes that build on it into the
CLI. All four revs move together so Cargo unifies them - verified with
`cargo tree`, one `comline-core` and one `comline-codegen` in the graph.

Checked end to end on a two-target project, since the bugs involved were
all "generated output is wrong" rather than anything a unit test sees:

- `retries: u8 = 5` now generates `pub retries: u8`, not `pub retries: u64`
- `name: string = "x"` now generates `pub name: String`, not `pub name: ,`
  which did not parse
- `const DEBUG: bool = true` generates `true` - it used to freeze as
  `false` in the IR regardless of what was written
- constants are emitted at all, in both targets, docstring included
- a file with nothing to derive no longer carries an unused `use serde`

core#92 is the interesting one: no generator change was needed for the
first three, because both generators already render a primitive's own
name. Fixing the IR fixed the output.
@Kinflou
Kinflou merged commit c633b1f into main Oct 13, 2026
2 checks passed
@Kinflou
Kinflou deleted the chore/bump-core-declared-types branch November 8, 2026 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant