Repository navigation
chore: bump core and both generators for declared types and constants - #65
Merged
Merged
Conversation
Carries core#92 and the two generator changes that build on it into the CLI. All four revs move together so Cargo unifies them - verified with `cargo tree`, one `comline-core` and one `comline-codegen` in the graph. Checked end to end on a two-target project, since the bugs involved were all "generated output is wrong" rather than anything a unit test sees: - `retries: u8 = 5` now generates `pub retries: u8`, not `pub retries: u64` - `name: string = "x"` now generates `pub name: String`, not `pub name: ,` which did not parse - `const DEBUG: bool = true` generates `true` - it used to freeze as `false` in the IR regardless of what was written - constants are emitted at all, in both targets, docstring included - a file with nothing to derive no longer carries an unused `use serde` core#92 is the interesting one: no generator change was needed for the first three, because both generators already render a primitive's own name. Fixing the IR fixed the output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Carries core#92 and the two generator changes that build on it into the
CLI. All four revs move together so Cargo unifies them - verified with
cargo tree, onecomline-coreand onecomline-codegenin the graph.Checked end to end on a two-target project, since the bugs involved were
all "generated output is wrong" rather than anything a unit test sees:
retries: u8 = 5now generatespub retries: u8, notpub retries: u64name: string = "x"now generatespub name: String, notpub name: ,which did not parse
const DEBUG: bool = truegeneratestrue- it used to freeze asfalsein the IR regardless of what was writtenuse serdecore#92 is the interesting one: no generator change was needed for the
first three, because both generators already render a primitive's own
name. Fixing the IR fixed the output.