Repository navigation
Declared targets are proven at build; resolve by floor (target versions step 3) - #95
Merged
Merged
Conversation
comline build checks each language config.idp declares before freezing (core's build_with): a generator handles the version, no dependency declares a higher one, every feature the schemas use is supported there, and past the verified range it warns under generation::unverified-version, which settings can raise to an error. A language this binary has no generator for fails the build. generate resolves through Registry::resolve with the same rules; comline.toml may raise lang_version, never lower it; targets prints each floor with its range; new scaffolds the Rust generator's floor. Fixtures and docs move to rust#1.85.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 3 of target versions (generation#76, proposal docs#76). It moves the cli off the removed
Registry::supportand ontoRegistry::resolve, and makes a declared target a promise thatcomline buildproves.comline buildproves every declared targetBefore anything is frozen, core#137's
build_withruns a check on eachcode_generation.languagesentry (newsrc/lang_targets.rs). Every problem is listed at once:rust#1.70.0is older than the rust generator handles: it needsrust#1.85.0or later"), and dotted numbers.dependency_configs, transitively. A dependency's minimum raises the package's, so building below it fails and names the dependency.generation::unverified-version. A package raises it withsettings = { diagnostics = { generation::unverified-version = { level = "error" } } }, through core's normal severity overrides.comline generateonly = [...]hint, now appears only when the language is really missing. A version below the floor gets the floor error.comline.tomlmay raiselang_version, never lower it: "targetrustsetslang_version = "1.85.0", below config.idp'srust#1.88.0- comline.toml can raise a target's version, never lower it".comline targetsandcomline newtargets: each line keepsname#floorfirst, then the range, e.g.rust#1.85.0 (1.85.0 or later; verified up to 1.99, and newer toolchains build its output).--featuresshows a feature's gate, and--jsoncarriesversions.new: scaffolds the Rust generator's floor from the registry, not a literal.Fixtures
rust#1.70.0→rust#1.85.0everywhere, and the lib-mode assertion now expects edition 2024 (comline-rust#70).Pins
core
a3f9eef(core#137), generationbbfadb2(generation#79), comline-rust577bdb2(#72), comline-typescriptc72d14e(#67). Merge after those.Tests
New tests:
comline.tomlmay raise a version but not lower it;targetsprints the range;All 120 pass, and
fmtandclippy -D warningsare clean.