Repository navigation
conformance: run the corpus over this generator, against goldens held here - #138
Merged
Merged
Conversation
added 2 commits
November 16, 2026 22:21
… here comline-conformance's suite that needs a generator moved out of generation, which no longer depends on this repository (generation#159): the protocol round trip, the golden comparison and the proof of every SUPPORT claim run here as codegen/tests/conformance.rs, over generation's corpus and harness. The goldens are generation's own, moved byte-identical (the sha256 of every file is unchanged); nothing was re-blessed. FEATURES.md and features.json are this generator's column of what generation used to write for both. Pins generation at the head of generation#159 until it merges.
Kinflou
force-pushed
the
conformance/own-goldens
branch
from
November 16, 2026 14:21
d40de52 to
0a99651
Compare
Kinflou
marked this pull request as ready for review
November 16, 2026 14:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of removing the dependency cycle between generation and the generators (generation#159). Runs generation's conformance corpus over this generator in this repository, against goldens held here.
What moves
codegen/tests/conformance.rs: the three checks that used to run in generation'sconformance/tests/conformance.rs, forrustonly, throughcomline_conformance::harness: the generator protocol round trip, the golden comparison (every fixture at every version boundary), and the proof of everySUPPORTclaim.codegen/tests/golden/<fixture>/rust/: generation'sconformance/tests/golden/<fixture>/rust/, 60 files, moved byte-identical. The sha256 of every file is the same before and after; nothing was re-blessed. A bless run in a scratch copy also produced no golden diff.FEATURES.mdandfeatures.json: this generator's column of the combined report generation used to write.features.jsonis exactly therustentry of the old file (samefeatureslist,generatorsholding only this one), checked by comparing the parsed JSON.Pin
comline-codegenandcomline-conformanceare pinned to31e808ff05632acbfa4f48d208b8d5a2fbca3b0e, the head of generation#159 (the harness is not on generation's default branch yet). Re-pin to the merge commit after it merges.Based on
mainafter #137 (generation e900919); this replaces itsrev =pins, incodegen/andxtask/.