Repository navigation
chore: repoint STD_REV at the regenerated std-extra - #38
Merged
Merged
Conversation
The required second step of comline-rust#37: that PR regenerated
`std-extra/` for the new `rust-version` line, so the pin every `lib`-mode
consumer reaches `comline_std` through was left one commit behind its own
contents - which is precisely what the `--check-pin` guard added there now
reports:
STD_REV (3fde4a9) predates changes to std-extra/ - every `lib`-mode
consumer would link the old std.
Pointed at #37's merge commit. Both `--check` and `--check-pin` pass, and
the compile test builds a crate against the new pin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The required second step of #37, which regenerated
std-extra/for the newrust-versionline and so leftSTD_REVone commit behind its own contents.This is exactly what the
--check-pinguard added in #37 reports:Pointed at #37's merge commit (
09cd2e0). Both--checkand--check-pinpass now, and the compile test builds a generated crate against the new pin.