Skip to content

chore: repoint STD_REV at the regenerated std-extra - #38

Merged
Kinflou merged 1 commit into
mainfrom
chore/repoint-std-rev
Oct 12, 2026
Merged

Kinflou merged 1 commit into
mainfrom
chore/repoint-std-rev

Conversation

@Kinflou

@Kinflou Kinflou commented Oct 12, 2026

Copy link
Copy Markdown
Member

The required second step of #37, which regenerated std-extra/ for the new
rust-version line and so left STD_REV one commit behind its own contents.

This is exactly what the --check-pin guard added in #37 reports:

STD_REV (3fde4a9) predates changes to std-extra/ - every `lib`-mode
consumer would link the old std.
Merge this, then repoint STD_REV in codegen/src/generator.rs at the merge
commit.

Pointed at #37's merge commit (09cd2e0). Both --check and --check-pin
pass now, and the compile test builds a generated crate against the new pin.

The required second step of comline-rust#37: that PR regenerated
`std-extra/` for the new `rust-version` line, so the pin every `lib`-mode
consumer reaches `comline_std` through was left one commit behind its own
contents - which is precisely what the `--check-pin` guard added there now
reports:

    STD_REV (3fde4a9) predates changes to std-extra/ - every `lib`-mode
    consumer would link the old std.

Pointed at #37's merge commit. Both `--check` and `--check-pin` pass, and
the compile test builds a crate against the new pin.
@Kinflou
Kinflou merged commit 5b1ba2b into main Oct 12, 2026
4 checks passed
@Kinflou
Kinflou deleted the chore/repoint-std-rev branch October 12, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant