Skip to content

conformance: vendor the corpus from the specification - #153

Merged
Kinflou merged 2 commits into
mainfrom
conformance/specification
Nov 9, 2026
Merged

Kinflou merged 2 commits into
mainfrom
conformance/specification

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 9, 2026

Copy link
Copy Markdown
Member

Part of stage 2 of ComlineProject/core#220. The conformance corpus moved from ComlineProject/runtime's runtime/conformance to ComlineProject/specification (runtime#113).

  • scripts/vendor-conformance.sh clones specification. It vendors the same files as before, plus VERSION, and pins them in test/conformance/SPEC_REV (was VECTORS_REV). At 3583aaa the vectors, profiles, benches and features.json are byte-identical to the previous copy.
  • CORE_REV is now a runtime commit only. comline-reference is built at it in ci.yml, nightly.yml and reports.yml.
  • They still move together. vendor-core.sh reads runtime/conformance/spec/REV at the runtime commit and refuses unless it equals SPEC_REV. It also refuses a runtime that vendors no specification. I checked both paths: ebfb792 is refused.
  • The core is re-vendored at runtime 0dffa7a, the merge of deps: pin generation for the doc renderers' Type/Value columns and titles #113. comline.mjs and comline.d.mts are unchanged, and the C ABI has been byte-identical since ebfb792. Only the wasm build differs.
  • Docs and comments are updated to match (README, bench docs, the test headers, reports-branch.md).

Tested locally:

  • vendor-core.sh --check rebuilds byte-identical.
  • vendor-conformance.sh --check passes.
  • npm run typecheck passes.
  • npm test with comline-reference at 0dffa7a: 125 of 125 pass.

Kinflou added 2 commits November 9, 2026 19:04
The conformance corpus moved from ComlineProject/runtime's
runtime/conformance to ComlineProject/specification. test/conformance/ is
vendored from there and pinned by SPEC_REV (was VECTORS_REV), with the
spec's VERSION.

The core and comline-reference are built at CORE_REV, a runtime commit.
They still move with the vectors: vendor-core.sh refuses a runtime whose
vendored specification (runtime/conformance/spec/REV) isn't SPEC_REV.
The first runtime commit that vendors the specification
(runtime/conformance/spec/REV = 3583aaa, SPEC_REV here). The C ABI and the
JS glue are unchanged since ebfb792; only the wasm build moves.
@Kinflou
Kinflou merged commit 6e64d65 into main Nov 9, 2026
28 checks passed
@Kinflou
Kinflou deleted the conformance/specification branch November 9, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant