Repository navigation
conformance: vendor the corpus from the specification - #153
Merged
Merged
Conversation
added 2 commits
November 9, 2026 19:04
The conformance corpus moved from ComlineProject/runtime's runtime/conformance to ComlineProject/specification. test/conformance/ is vendored from there and pinned by SPEC_REV (was VECTORS_REV), with the spec's VERSION. The core and comline-reference are built at CORE_REV, a runtime commit. They still move with the vectors: vendor-core.sh refuses a runtime whose vendored specification (runtime/conformance/spec/REV) isn't SPEC_REV.
The first runtime commit that vendors the specification (runtime/conformance/spec/REV = 3583aaa, SPEC_REV here). The C ABI and the JS glue are unchanged since ebfb792; only the wasm build moves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of stage 2 of ComlineProject/core#220. The conformance corpus moved from ComlineProject/runtime's
runtime/conformanceto ComlineProject/specification (runtime#113).scripts/vendor-conformance.shclonesspecification. It vendors the same files as before, plusVERSION, and pins them intest/conformance/SPEC_REV(wasVECTORS_REV). At3583aaathe vectors, profiles, benches andfeatures.jsonare byte-identical to the previous copy.CORE_REVis now a runtime commit only.comline-referenceis built at it inci.yml,nightly.ymlandreports.yml.vendor-core.shreadsruntime/conformance/spec/REVat the runtime commit and refuses unless it equalsSPEC_REV. It also refuses a runtime that vendors no specification. I checked both paths:ebfb792is refused.0dffa7a, the merge of deps: pin generation for the doc renderers' Type/Value columns and titles #113.comline.mjsandcomline.d.mtsare unchanged, and the C ABI has been byte-identical sinceebfb792. Only the wasm build differs.reports-branch.md).Tested locally:
vendor-core.sh --checkrebuilds byte-identical.vendor-conformance.sh --checkpasses.npm run typecheckpasses.npm testwithcomline-referenceat0dffa7a: 125 of 125 pass.