Skip to content

Render an @unverified protocol's frozen reasons, not a recomputed cause - #160

Merged
Kinflou merged 3 commits into
mainfrom
fix/frozen-unverified-reasons
Nov 12, 2026
Merged

Kinflou merged 3 commits into
mainfrom
fix/frozen-unverified-reasons

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 12, 2026

Copy link
Copy Markdown
Member

Part of ComlineProject/core#253. Needs ComlineProject/core#263.

  • Pins comline-core (codegen, its dev-dependency and xtask) to a5bebdfbf71c57dba742a465bd4a08d53d650e56, the head of core#263, by editing the manifests.
  • unverified_doc renders unverified::frozen_reasons in place of unverified::cause(parameters, &Encodings::default()), so a set of bounded_size or encoding_conformance no longer reads as (handshake ...). One reason for everything given up reads as Reason given: ...; a keyed one reads per guarantee.
  • Tests: bounded-size-only and encoding-conformance docs name their reason, not a handshake; a keyed marker renders each reason.

Kinflou added 2 commits November 12, 2026 12:18
…se (core#253)

Pins core to the head of core#263, which adds unverified::frozen_reasons.
The doc no longer says '(handshake ...)' for a set of bounded_size or
encoding_conformance; it gives the reason the build recorded for each
guarantee.
@Kinflou
Kinflou marked this pull request as ready for review November 12, 2026 05:10
@Kinflou
Kinflou merged commit 66b13c3 into main Nov 12, 2026
41 checks passed
@Kinflou
Kinflou deleted the fix/frozen-unverified-reasons branch November 12, 2026 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant