Skip to content

conformance: vendor the specification at 0.11 (69882e9) - #166

Merged
Kinflou merged 1 commit into
mainfrom
conformance/spec-69882e9
Nov 13, 2026
Merged

Kinflou merged 1 commit into
mainfrom
conformance/spec-69882e9

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 13, 2026

Copy link
Copy Markdown
Member

Part of #162 (first item: re-vendor the specification).

Why

Since cli#156 the comline CLI's conformance crate is spec 0.11 and requires every framing profile to state protocol. This repo vendored the specification at 3583aaa, so the "runtime - comline conformance" job fails with test/conformance/profiles/datagram@1.json: missing field protocol, on every PR and on main.

What is vendored

  • scripts/vendor-conformance.sh 69882e9: the revision the runtime pins (runtime/conformance/spec/REV). Spec 0.11: the protocol fact and directions in the profiles, the sizes-packed/sizes-msgpack/sizes-json vectors and features, and framing-datagram3/request-two-byte-protocol. SPEC_REV moves with it. (The script vendors only the corpus, not the catalog.)
  • scripts/vendor-core.sh 8f8c0cb (runtime#123, the commit that vendors 69882e9): vendor-core.sh requires the runtime revision at CORE_REV to be proven by SPEC_REV, so --check could not pass with CORE_REV at 0dffa7a. Only comline_runtime_ffi.wasm differs; comline.mjs and comline.d.mts are byte-identical.

New cases

conformance-report.json changes only by those four additions.

Checked locally

npm run typecheck, npm test (125 pass, 0 skipped with comline-reference built at 8f8c0cb), typecheck:generated, vendor-conformance.sh --check, vendor-core.sh --check, and the CI's comline conformance commands with the CLI at cli main 684a4f8: datagram@1, datagram@2, jsonrpc@1, packed@1 and comline@1 all pass; json@1 (non-gating) fails only its two known cases (#57).

comline-typescript vendored the specification at 3583aaa. The comline CLI's
conformance crate has been spec 0.11 since cli#156 and requires every framing
profile to state `protocol`, so the "runtime - comline conformance" job failed
on the old corpus: "profiles/datagram@1.json: missing field `protocol`".

Re-vendored with scripts/vendor-conformance.sh at 69882e9, the revision the
runtime pins (runtime/conformance/spec/REV): the `protocol` fact in the framing
profiles, `directions`, the sizes-packed/-msgpack/-json vectors and
framing-datagram3/request-two-byte-protocol. SPEC_REV moves with it, and so
does the vendored core: scripts/vendor-core.sh requires the runtime revision
CORE_REV names to be proven by SPEC_REV, so core/ is re-vendored at runtime
8f8c0cb (the commit that vendors 69882e9). comline.mjs and comline.d.mts are
unchanged; only the wasm differs.

The size features are claimed unsupported (comline-typescript#162): their
`size` cases carry no bytes, so the harness reports them not implemented
instead of failing on the missing field. Nothing new is claimed.
@Kinflou
Kinflou marked this pull request as ready for review November 13, 2026 05:12
@Kinflou
Kinflou merged commit c3c59de into main Nov 13, 2026
41 checks passed
@Kinflou
Kinflou deleted the conformance/spec-69882e9 branch November 13, 2026 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant