Repository navigation
conformance: vendor the specification at 0.11 (69882e9) - #166
Merged
Merged
Conversation
comline-typescript vendored the specification at 3583aaa. The comline CLI's conformance crate has been spec 0.11 since cli#156 and requires every framing profile to state `protocol`, so the "runtime - comline conformance" job failed on the old corpus: "profiles/datagram@1.json: missing field `protocol`". Re-vendored with scripts/vendor-conformance.sh at 69882e9, the revision the runtime pins (runtime/conformance/spec/REV): the `protocol` fact in the framing profiles, `directions`, the sizes-packed/-msgpack/-json vectors and framing-datagram3/request-two-byte-protocol. SPEC_REV moves with it, and so does the vendored core: scripts/vendor-core.sh requires the runtime revision CORE_REV names to be proven by SPEC_REV, so core/ is re-vendored at runtime 8f8c0cb (the commit that vendors 69882e9). comline.mjs and comline.d.mts are unchanged; only the wasm differs. The size features are claimed unsupported (comline-typescript#162): their `size` cases carry no bytes, so the harness reports them not implemented instead of failing on the missing field. Nothing new is claimed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #162 (first item: re-vendor the specification).
Why
Since cli#156 the
comlineCLI's conformance crate is spec 0.11 and requires every framing profile to stateprotocol. This repo vendored the specification at3583aaa, so the "runtime - comline conformance" job fails withtest/conformance/profiles/datagram@1.json: missing field protocol, on every PR and on main.What is vendored
scripts/vendor-conformance.sh 69882e9: the revision the runtime pins (runtime/conformance/spec/REV). Spec 0.11: theprotocolfact anddirectionsin the profiles, thesizes-packed/sizes-msgpack/sizes-jsonvectors and features, andframing-datagram3/request-two-byte-protocol.SPEC_REVmoves with it. (The script vendors only the corpus, not the catalog.)scripts/vendor-core.sh 8f8c0cb(runtime#123, the commit that vendors 69882e9):vendor-core.shrequires the runtime revision atCORE_REVto be proven bySPEC_REV, so--checkcould not pass withCORE_REVat0dffa7a. Onlycomline_runtime_ffi.wasmdiffers;comline.mjsandcomline.d.mtsare byte-identical.New cases
framing-datagram3/request-two-byte-protocolpasses (datagram@3 is already claimed); it is added toproven_byin the report.sizes-*features are claimedunsupported(tracking Runtime: exact value sizes and the specification's size vectors (sizes-packed, sizes-msgpack, sizes-json) #162), withproven_by: [], becauseconformance.test.tsrequires a claim per feature. Theirsizecases carry nobytes, so the harness now reports them not implemented rather than failing on the missing field. Nothing new is claimed; the sizes work is the rest of Runtime: exact value sizes and the specification's size vectors (sizes-packed, sizes-msgpack, sizes-json) #162.conformance-report.jsonchanges only by those four additions.Checked locally
npm run typecheck,npm test(125 pass, 0 skipped withcomline-referencebuilt at 8f8c0cb),typecheck:generated,vendor-conformance.sh --check,vendor-core.sh --check, and the CI'scomline conformancecommands with the CLI at cli main684a4f8: datagram@1, datagram@2, jsonrpc@1, packed@1 and comline@1 all pass; json@1 (non-gating) fails only its two known cases (#57).