Repository navigation
Leave unreached dependency protocols off the connection (generation#143) - #168
Merged
Merged
Conversation
added 2 commits
November 15, 2026 02:56
Pin generation at da81b68 and use its dependency-aware entry points: package_connection_among, on_connection_among and addressing_in, with the request's dependencies. A dependency's protocol is still generated as a type, but is no longer in Services, the package connection or the Hello, and is addressed by position.
Kinflou
marked this pull request as ready for review
November 14, 2026 19:29
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopts ComlineProject/generation#146 (da81b68), which closes generation#143: a dependency's protocol the package doesn't reach (none can be yet, core#277) is generated as a type, but is never addressed by the package's wire numbers, checked, or put on its connection.
At the previous pin, a package with a protocol of its own also had the dependency's protocol in
Services, the package connection.Changes
comline-codegenandcomline-conformance(codegen, xtask) at da81b68. Core stays at 868e831.connections::package_connection->package_connection_among(&req.schemas, &req.dependencies).connections::on_connection->on_connection_among(schemas, &req.dependencies, ..)(the schema emitter, derived names).facts::addressing->addressing_in(req, ..): a dependency's protocol is addressed by position.checkCallis imported only for a protocol the package reaches.facts::check(req)already took the request;facts::hellotakes the connection built above.Tests
codegen/tests/dependency_protocols.rsgenerates generation'sdependency_protocol()anddependency_and_own_protocols()fixtures. Output is kept inruntime/test/generated/dependency/{only,own}(blessed withTS_BLESS=1), so the Node job'stypecheck:generatedtype-checks it. Asserts:connection.ts;Services, the Hello and the protocol map name onlyChat, with noFooorlocaldepsinconnection.ts;stdio.rsandgenerate.rsfill the newGenerateRequest::dependencies.Not done
connections::check(bare-name clashes) has no dependency-aware variant in generation#146 and still sees a dependency's protocols. The CLI fillingGenerateRequest::dependenciesis a follow-up in cli (generation#146's list).