Skip to content

conformance: run the corpus over this generator, against goldens held here - #177

Merged
Kinflou merged 2 commits into
mainfrom
conformance/own-goldens
Nov 16, 2026
Merged

Kinflou merged 2 commits into
mainfrom
conformance/own-goldens

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Part of removing the dependency cycle between generation and the generators (generation#159). Runs generation's conformance corpus over this generator in this repository, against goldens held here.

What moves

  • codegen/tests/conformance.rs: the three checks that used to run in generation's conformance/tests/conformance.rs, for typescript only, through comline_conformance::harness: the generator protocol round trip, the golden comparison (every fixture at every version boundary), and the proof of every SUPPORT claim.
  • codegen/tests/golden/<fixture>/typescript/: generation's conformance/tests/golden/<fixture>/typescript/, 76 files, moved byte-identical. The sha256 of every file is the same before and after; nothing was re-blessed. A bless run in a scratch copy also produced no golden diff.
  • FEATURES.md and features.json: this generator's column of the combined report generation used to write. features.json is exactly the typescript entry of the old file (same features list, generators holding only this one), checked by comparing the parsed JSON.

Pin

comline-codegen and comline-conformance are pinned to 31e808ff05632acbfa4f48d208b8d5a2fbca3b0e, the head of generation#159 (the harness is not on generation's default branch yet). Re-pin to the merge commit after it merges.

Based on main after #176 (generation e900919); this replaces its rev = pins, in codegen/ and xtask/.

Kinflou added 2 commits November 16, 2026 23:01
… here

comline-conformance's suite that needs a generator moved out of generation,
which no longer depends on this repository (generation#159): the protocol
round trip, the golden comparison and the proof of every SUPPORT claim run
here as codegen/tests/conformance.rs, over generation's corpus and harness.

The goldens are generation's own, moved byte-identical (the sha256 of every
file is unchanged); nothing was re-blessed. FEATURES.md and features.json
are this generator's column of what generation used to write for both.

Pins generation at the head of generation#159 until it merges.
@Kinflou
Kinflou force-pushed the conformance/own-goldens branch from 4e951ac to af8ea90 Compare November 16, 2026 15:01
@Kinflou
Kinflou marked this pull request as ready for review November 16, 2026 15:25
@Kinflou
Kinflou merged commit 671f27e into main Nov 16, 2026
41 checks passed
@Kinflou
Kinflou deleted the conformance/own-goldens branch November 16, 2026 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant