Repository navigation
Lint with ESLint 10 and typescript-eslint 8, in a flat config - #42
Merged
Merged
Conversation
Kinflou
force-pushed
the
deps/vsce-4-node-22
branch
from
November 16, 2026 00:02
4035b3e to
d5ae639
Compare
Kinflou
force-pushed
the
deps/eslint-10-flat-config
branch
from
November 16, 2026 00:13
2305732 to
acc9b42
Compare
Kinflou
changed the base branch from
deps/vsce-4-node-22
to
deps/bundle-esbuild
November 16, 2026 00:13
Kinflou
force-pushed
the
deps/eslint-10-flat-config
branch
from
November 16, 2026 00:23
acc9b42 to
b202a0b
Compare
Kinflou
marked this pull request as ready for review
November 16, 2026 00:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #45 (bundling), which is on main as soon as #45 merges. Moves linting from ESLint 8 and typescript-eslint 6 to ESLint 10.15.0 and typescript-eslint 8.72.2, with a flat config.
What changed
eslint.config.mjsreplaces.eslintrc.json, which is removed..vscodeignorenames the new file where it named the old one.package.json:eslint^8.0.0 to ^10.15.0,@typescript-eslint/parserand/eslint-plugin^6.0.0 to ^8.72.2, and a new@stylistic/eslint-plugin^6.0.0 (seesemi).lintiseslint src: flat config has no--ext, so thefilespattern in the config says what is linted.typescriptstays on ^5 (typescript-eslint 8.72.2 supports<6.1.0).The same rules
.eslintrc.jsoneslint.config.mjs@typescript-eslint/naming-convention: warn@typescript-eslint/semi: warn,semi: off@stylistic/semi: warnalways). Coresemiexists in ESLint 10 but is deprecated and does not know TypeScript syntax (type aliases, abstract and declared members), which is what the@typescript-eslintversion added. Thesemi: offline goes with it: a flat config with noextendshas no coresemion to switch off.curly,eqeqeq,no-throw-literal: warnparser: @typescript-eslint/parser,parserOptions.ecmaVersion: 6,sourceType: modulelanguageOptionswith the same threeplugins: ["@typescript-eslint"]plugins: { '@typescript-eslint', '@stylistic' }ignorePatterns: out, node_modules, .vscode-testglobalIgnores(['out/**', '.vscode-test/**'])node_modulesis ignored by default.eslint src --ext tseslint srcwithfiles: ['**/*.ts']There was no
extendsbefore and there is none now, so only these five rules run; I did not add the recommended sets (that would be new rules, not a migration). Nothing is turned off, and the two inlineeslint-disable-next-line @typescript-eslint/naming-conventioninsrc/extension.tsstill name a rule that exists.Findings in the code
None new. The lint output on this branch is the same 24 warnings, 0 errors, as on
main: all@typescript-eslint/naming-convention, insrc/resolve.test.ts, on environment-variable names used as object keys (PATH,FLATPAK_ID,RUST_LOG,CLICOLOR_FORCE, ...); the lines and columns match. They are the existing warnings and I left them as warnings.Lint can now fail CI.
ci.yml'sLint TypeScriptstep hadcontinue-on-error: true, so an error never failed the job. It is gone. Warnings still exit 0, so the 24 do not fail the step; an error (a rule set toerror, a config that does not load, a parser failure) does. On this branch the step passes with✖ 24 problems (0 errors, 24 warnings).Alerts
This pull request clears 1 more:
minimatch9.0.3 (alert 9) is gone, as@typescript-eslint8 no longer pins it. Across the stack, 53 of 54 are cleared and all 10 shipped ones.Remaining (1):
minimatch, alert 79 (a denial of service in globs; every version from 7.0.0 up to below 11.0.1 is in its range, fixed in 11.0.1). The lock holdsminimatch10.2.6 because@vscode/vsce4.1.1 depends on^10.2.6and typescript-eslint 8.72.2'stypescript-estreeon^10.2.2; both are the latest releases. ESLint 10 itself usesminimatch11.0.8. No upgrade within those ranges clears it. Decision for you: aresolutionsentry forminimatch^11(I did not add one), or wait for vsce and typescript-eslint to move. It is development-only: the.vsixholds nonode_modules, and the bundle's onlyminimatchisvscode-languageclient's 5.1.9.The
.vsixNothing in the package changes with this pull request: since #45 it holds the bundle and no
node_modules, so the development tree (hereminimatch10 andbrace-expansion5 replacing eslint 8'sminimatch3) cannot reach it. Package Test's bundle report on this branch lists the same packages as #45, withbalanced-match,brace-expansionandminimatchnow allvscode-languageclient's own, and the Node 16 load check passes. The.vsixis.eslintrc.json-free as before;eslint.config.mjsis in.vscodeignore.CI
ci.ymldoes not run on pull requests whose base is notmain, so Lint and Compile and Package Test ran on #46 (this branch againstmain, a throwaway, closed): run 43779128244 passed, with the lint output above. On this pull request: Release Extension (all six Package jobs), Flatpak, Lint and CodeQL.