Repository navigation
Run the specification's compiler conformance cases (#224) - #243
Merged
Merged
Conversation
added 2 commits
November 11, 2026 10:43
#224) Vendors compiler/cases/*.json beside the size vectors and runs each: the package graph is laid out in a temp dir and built with compile_package, then the frozen given-up sets, acknowledgements, diagnostics and errors compared. Pins comline-catalog to the unmerged specification#5 head.
…h a bounded array)
Kinflou
marked this pull request as ready for review
November 11, 2026 11:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs the specification's compiler conformance cases (ComlineProject/specification#5, core#224) against core. Each case is a schema graph given as data, together with the outcome any compiler must reproduce.
Spec pin.
tests/spec/vendors the specification at0685006, the merge commit of specification#5, andcomline-catalogis pinned to the same commit, so the test thatREVequals the catalog rev holds.What it does
tests/package/compiler_cases.rshandles each of the 42 cases:buildpackage withcompile_package, which resolves dependencies by path;expect.The comparison covers:
[code]markers in the rendered error) and anyerror_containstext.Every mismatch is reported with its case id before the test fails. The runner has a
CORE_DISAGREESlist for cases that core gets wrong; it is empty, so every case must pass.The test runs in the
--features depsjobs, because the dependency cases need dependency resolution.What running it found
39 of 42 cases matched on the first run. The 3 recursion cases were wrong in the spec, not in core:
optional next: Node.optionalfield end a cycle yet (OPTIONAL_ENDS_A_CYCLE), because the Rust generator doesn't box optional fields. So it refused the type withvalidation::struct-cyclebefore checking bounds.9e590a2changes them to recurse throughkids: Node[max 4], which leaves depth as the only unbounded measure.No core bugs were found, including in the three-package chain cases.