Repository navigation
CI: reusable workflows, CI images, hardening - #257
Merged
Merged
Conversation
…, an exact toolchain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 4 of the CI overhaul for core. Draft; settings are untouched. All checks are green.
Reusable workflows
Pinned at ComlineProject/.github
797d473553d7f2fc50895bb2573acb83ac63c7cb.build_test.yml: the toolchain matrix (stable, beta, nightly), the cross-platform legs (arm64 Linux, macOS, Windows), the-p comline-core --features depstest run and an ubuntu-26.04 canary are one call torust-ci.yml.bench.yml: the instruction-count gate and the publish job are one call to the reusablebench.yml, in theci-benchimage (valgrind and iai-callgrind-runner in it; the apt andcargo installsteps are gone; the defaultcontainer-optionscarriesseccomp=unconfined).bench-report.py, the ledger and the 1% limit are unchanged.fuzz.yml: one call to the reusablefuzz.yml, in theci-fuzzimage. Same four targets, dictionaries,-max_len=1024, 60 s on a pull request and 600 s nightly.lint.yml(new): one call to the reusable lint (actionlint, andrenovate.jsonvalidated with--strict).Stayed local: in
build_test.yml,spec_vectors(a one-line check) andir_only(the reusable workflow has no job for the wasm targets; it runs in theci-wasmimage, which has both wasm targets), andreports.yml(the Observatory coverage and compile-time actions; no reusable workflow covers it).Hardening
runs-on: ubuntu-24.04everywhere (the ubuntu-26.04 canary is the reusablerust-ci.yml's, withcontinue-on-error; the macOS and Windows legs are pinned by it). Top-levelcontents: read, with write only on the publish jobs; the bench and fuzz callers grantcontents: write(andissues: writefor fuzz) because a called workflow can't hold more than its caller, and the reusable workflows ask for write only in their publish jobs, which never run on a pull request.persist-credentials: falseon every checkout exceptreports.yml's publish job, which pushes. Concurrency by workflow and ref, cancelling on pull requests only (lint.yml's group is not namedlint-..., the reusable workflow's own group, as groups are case-insensitive).timeout-minuteson every job (the reusable workflows set theirs). Everyuses:is a 40-hex SHA with a version comment (the observatory@v1refs too; the .github repo has no tags yet).harden-runner(audit) is the first step of the VM jobs in this repo; it doesn't run in container jobs (ir_onlyand the bench and fuzz jobs).No apt, brew, choco or curl-pipe installs remain in
.github/. There is no cue job in core. Every image is used by digest.Other
renovate.jsonextendsgithub>ComlineProject/.github:renovate-config.rust-toolchain.tomlpins 1.99.1 instead ofstable. The beta and nightly legs of the matrix are kept and pass.reportsbranch will step once at the first run after the merge. Thresholds are unchanged.