Skip to content

CI: reusable workflows, CI images, hardening - #257

Merged
Kinflou merged 3 commits into
masterfrom
ci-hardening
Nov 11, 2026
Merged

Kinflou merged 3 commits into
masterfrom
ci-hardening

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Phase 4 of the CI overhaul for core. Draft; settings are untouched. All checks are green.

Reusable workflows

Pinned at ComlineProject/.github 797d473553d7f2fc50895bb2573acb83ac63c7cb.

  • build_test.yml: the toolchain matrix (stable, beta, nightly), the cross-platform legs (arm64 Linux, macOS, Windows), the -p comline-core --features deps test run and an ubuntu-26.04 canary are one call to rust-ci.yml.
  • bench.yml: the instruction-count gate and the publish job are one call to the reusable bench.yml, in the ci-bench image (valgrind and iai-callgrind-runner in it; the apt and cargo install steps are gone; the default container-options carries seccomp=unconfined). bench-report.py, the ledger and the 1% limit are unchanged.
  • fuzz.yml: one call to the reusable fuzz.yml, in the ci-fuzz image. Same four targets, dictionaries, -max_len=1024, 60 s on a pull request and 600 s nightly.
  • lint.yml (new): one call to the reusable lint (actionlint, and renovate.json validated with --strict).

Stayed local: in build_test.yml, spec_vectors (a one-line check) and ir_only (the reusable workflow has no job for the wasm targets; it runs in the ci-wasm image, which has both wasm targets), and reports.yml (the Observatory coverage and compile-time actions; no reusable workflow covers it).

Hardening

runs-on: ubuntu-24.04 everywhere (the ubuntu-26.04 canary is the reusable rust-ci.yml's, with continue-on-error; the macOS and Windows legs are pinned by it). Top-level contents: read, with write only on the publish jobs; the bench and fuzz callers grant contents: write (and issues: write for fuzz) because a called workflow can't hold more than its caller, and the reusable workflows ask for write only in their publish jobs, which never run on a pull request. persist-credentials: false on every checkout except reports.yml's publish job, which pushes. Concurrency by workflow and ref, cancelling on pull requests only (lint.yml's group is not named lint-..., the reusable workflow's own group, as groups are case-insensitive). timeout-minutes on every job (the reusable workflows set theirs). Every uses: is a 40-hex SHA with a version comment (the observatory @v1 refs too; the .github repo has no tags yet). harden-runner (audit) is the first step of the VM jobs in this repo; it doesn't run in container jobs (ir_only and the bench and fuzz jobs).

No apt, brew, choco or curl-pipe installs remain in .github/. There is no cue job in core. Every image is used by digest.

Other

  • renovate.json extends github>ComlineProject/.github:renovate-config.
  • rust-toolchain.toml pins 1.99.1 instead of stable. The beta and nightly legs of the matrix are kept and pass.
  • Bench baselines: core commits none; the gate benches base and head in one job. The move to valgrind 3.24 (from 3.22) shifts counts by up to about 0.44%, so the published history on the reports branch will step once at the first run after the merge. Thresholds are unchanged.

@Kinflou Kinflou closed this Nov 11, 2026
@Kinflou Kinflou reopened this Nov 11, 2026
@Kinflou Kinflou closed this Nov 11, 2026
@Kinflou Kinflou reopened this Nov 11, 2026
@Kinflou
Kinflou marked this pull request as ready for review November 11, 2026 22:40
@Kinflou
Kinflou merged commit 9b1bb0f into master Nov 11, 2026
35 checks passed
@Kinflou
Kinflou deleted the ci-hardening branch November 11, 2026 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant