Repository navigation
Pin the specification at 0.11: the framing fact protocol - #271
Merged
Merged
Conversation
Pin comline-catalog and the vendored tests/spec/REV at the head of ComlineProject/specification#9 (69882e9), and take its four framing profiles into the embedded official package: each now states `protocol` (`named` for datagram@2 and datagram@3, `unnamed` for datagram@1 and jsonrpc@1). The profile hashes in official_units.json follow. Profile gains `names_protocol()` and `both_directions()`, typed readers of the two facts for generation and the CLI. The hand-written profiles in tests state `protocol` too, as a framing must.
…`protocol` The fixture declares its own framing, and spec 0.11 has every framing profile state `protocol`. That changes the frozen `Encoding` unit the pin covers, so the pin moves with its input. CONTENT_HASH_SCHEME is unchanged: official encodings are looked up, never frozen into a package's config, so pins of packages without a framing of their own don't move.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves core to ComlineProject/specification#9 (spec 0.11, the framing fact
protocol), for ComlineProject/generation#137 step 2.comline-catalogandtests/spec/REVare at Testing: fuzzing, IR round-trip, coverage, cross-platform CI #9's head,69882e92971e243b6b74a539a13b534d95b3abf7; Testing: fuzzing, IR round-trip, coverage, cross-platform CI #9 merges with a merge commit, so the pin stays reachable.protocol;official_units.jsonis re-blessed (their profile hashes).Profile::names_protocol()andProfile::both_directions()read the two facts for generation and the CLI.protocoltoo.