Repository navigation
datagram@3 and comline@2 are the defaults - #150
Merged
Merged
Conversation
Names the new defaults wherever the old ones were named, drops the "available, not the default" notes, explains the breaking bump a package taking the defaults gets on its first release after the change and how to keep the old wire, the per-package rule for the default handshake, and that comline generate works out provisional numbers without a build (runtime#15).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of ComlineProject/runtime#15, the default flip: core#208, generation#122, comline-rust#109, comline-typescript#136, cli#137.
New defaults everywhere they're named:
datagram@3andcomline@2, in the protocol, packages and call-system guides, both languages' framing pages,config.idp's reference,inspect, the language feature rows,versioning.md's "in play" and the extending-encodings page.Notes removed: "
datagram@3is available, not the default", "comline@2is available, not the default" (with its "generators don't embed the facts yet"), and call-system's "not yet the default".New section, Handshakes > Defaults before
comline@2:datagram@2/comline@1;wire = { framing = "datagram@2" }andhandshake = "comline@1"keeps the old wire with no change.The framings page, the packages guide and versioning's Storage section link to it.
Default handshake per package:
comline@2where all the package's protocols are ondatagram@3, elsecomline@1for those naming none (handshakes page,config.idpreference, protocol guide).Generate without a build: versioning's Number section and the CLI table explain that
comline generateuses the last build's numbers when nothing changed, and otherwise works them out as the next build would. Those numbers are provisional until a release.versioning.md'sby_idrows already say what applies by framing; "in play" now namesdatagram@3as the default, withdatagram@2for versions built before.No pages moved.
sync-official-encodings.py --checkpasses (the encodings package didn't change).sync-language-support.py --checkwas already out of date on main before this PR, so I only edited the connections rows by hand. They match generation#122'sfeatures.jsonand stay red until generation merges.