Repository navigation
Design: the playground and tutorial share comline-web-kit - #177
Merged
Merged
Conversation
The playground's editor and simulate view are now a package, comline-web-kit, that the tutorial installs by git (ComlineProject/playground#118), and the tutorial's "Try it" lesson runs on the view's lesson layout. - playground-and-tutorial.md: "Not sharing yet" becomes what's shared and how; the reality note and the framework decision say the shared part is framework-neutral TS, with no Svelte component library. - brand-assets.md: shared-web is no longer a consumer or the planned relay; the kit's --cl-* properties are where shared colours belong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 4 of ComlineProject/playground#118. The two design pages now describe what's being built there.
design/playground-and-tutorial.mdcomline-web-kit". The playground's editor and simulate view are a package, a workspace of the playground repo that the tutorial installs by git. The note describes the simulate view's lesson layout, which the tutorial's "Try it" lesson runs on. It also covers the editor entry point, which no lesson uses yet, and the theming through--cl-*properties.design/brand-assets.mdshared-webis no longer listed as a brand consumer or as the planned shared layer. The relay follow-up now points at the kit's--cl-*properties as the place for colours that several sites need.Merging
Merge after the playground PRs (ComlineProject/playground#119, #120) and the tutorial PR (ComlineProject/tutorial#11), so the pages describe what's on
main.zensical build --strictpasses locally.