Repository navigation
typescript: the lockstep page follows the Protocols guide's Mail example - #190
Merged
Merged
Conversation
The page showed a Chat protocol that matched no golden. It now shows Mail (send_message, fetch_inbox, RecipientNotFound) and the TypeScript output generation's lockstep golden pins, as the Rust page already does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rewrites
docs/docs/languages/typescript/client-and-server.mdfrom itsChatprotocol to the Protocols guide'sMailexample, so it matches the Rust lockstep page and the golden both are now quoted from.What changed
Mail(send_messagewith@timeout_ms = 1000,fetch_inbox,RecipientNotFound). The generated snippet is quoted from the new TypeScriptlockstepgolden in conformance: goldens for the default connection and the lockstep framing generation#154, with only/* … *//// …trims.noteexample is gone, becauseMailhas no one-way function.@timeout_ms(the golden makes a plaincall; the Rust client passes it tocall_with_timeout).bigintbullet no longer usesseq(Messagehas nou64); it points atIR_HASHand says what au64field would be.Rust page
I checked the Rust page's codegen snippet line by line against the new Rust
lockstepgolden (generation#154): every line matches, in order, with only the/* … */and// …trims, andIR_HASH(0x7ea94b595fcf4393) is the golden's. No change to the Rust page was needed.Depends on generation#154 for the golden the snippets quote; that PR is a draft.