Repository navigation
Read the code generators' features.json, one per generator - #194
Merged
Merged
Conversation
added 2 commits
November 16, 2026 23:28
Generation's combined features.json goes away (generation#159). Each generator publishes its own; the script fetches both and joins their generators, so the Languages pages render as before. --file and --rev become --generator NAME=FILE and --generator-rev. The pages change only in the notice line. The conformance docs now say generation holds the corpus and the harness, and each generator runs it against its own goldens.
…eatures.json Not part of the repointing: the committed pages already lagged generation master (fixtures added since the last refresh), so the drift check fails on any change to the script. Separate commit so it can be dropped and merged on its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generation's combined
features.jsongoes away with ComlineProject/generation#159. Each generator now publishes its own at its repo root onmain(comline-rust 22110d8, comline-typescript 671f27e): the samefeatureslist, and only its own entry ingenerators. Joining the twogeneratorsarrays gives exactly the old file (checked against generation master'sfeatures.json).Script
scripts/sync-language-support.pyfetches both and joins them (GENERATORS; it exits if the files list different features or a file doesn't hold exactly its own generator).--fileand--revbecome--generator NAME=FILE(repeatable) and--generator-rev(defaultmain). The NOTICE now reads "Rendered from each code generator's features.json".Rendered output: the old script on generation master's
features.jsonand the new one on the two generators' files produce the sameindex.md,rust.mdandtypescript.md, except the NOTICE comment line in each (the first commit changes only that line in the pages).Drift workflow
language-support-drift.ymlneeds no change beyond its comment: it only runs the script, which fetches over HTTPS from raw.githubusercontent.com.Pages
reference/conformance/{generators,index,reports}.md,design/{runtime-repo-structure,generation}.mdnow say generation holds the corpus and a generator-agnostic harness, and each generator runs it against its own goldens and publishes its own report.proposals/shared-runtime-core/verification.md,project-dashboard.mdandtarget-versions.mdare historical, so they get a parenthetical or a bullet under "Where it differs from the text".Second commit
The committed Languages pages already lagged generation master (new fixtures in the Proven by columns), so the drift check fails on any PR touching the script. The second commit refreshes them; it changes only those lists. Drop it and merge the refresh separately if you prefer.
Statements that generation depends only on core are true once generation#159 merges.