Skip to content

Read the code generators' features.json, one per generator - #194

Merged
Kinflou merged 2 commits into
mainfrom
features-split/per-generator-features
Nov 16, 2026
Merged

Kinflou merged 2 commits into
mainfrom
features-split/per-generator-features

Conversation

@Kinflou

@Kinflou Kinflou commented Nov 16, 2026

Copy link
Copy Markdown
Member

Generation's combined features.json goes away with ComlineProject/generation#159. Each generator now publishes its own at its repo root on main (comline-rust 22110d8, comline-typescript 671f27e): the same features list, and only its own entry in generators. Joining the two generators arrays gives exactly the old file (checked against generation master's features.json).

Script

scripts/sync-language-support.py fetches both and joins them (GENERATORS; it exits if the files list different features or a file doesn't hold exactly its own generator). --file and --rev become --generator NAME=FILE (repeatable) and --generator-rev (default main). The NOTICE now reads "Rendered from each code generator's features.json".

Rendered output: the old script on generation master's features.json and the new one on the two generators' files produce the same index.md, rust.md and typescript.md, except the NOTICE comment line in each (the first commit changes only that line in the pages).

Drift workflow

language-support-drift.yml needs no change beyond its comment: it only runs the script, which fetches over HTTPS from raw.githubusercontent.com.

Pages

reference/conformance/{generators,index,reports}.md, design/{runtime-repo-structure,generation}.md now say generation holds the corpus and a generator-agnostic harness, and each generator runs it against its own goldens and publishes its own report. proposals/shared-runtime-core/verification.md, project-dashboard.md and target-versions.md are historical, so they get a parenthetical or a bullet under "Where it differs from the text".

Second commit

The committed Languages pages already lagged generation master (new fixtures in the Proven by columns), so the drift check fails on any PR touching the script. The second commit refreshes them; it changes only those lists. Drop it and merge the refresh separately if you prefer.

Statements that generation depends only on core are true once generation#159 merges.

Kinflou added 2 commits November 16, 2026 23:28
Generation's combined features.json goes away (generation#159). Each generator publishes its own; the script fetches both and joins their generators, so the Languages pages render as before. --file and --rev become --generator NAME=FILE and --generator-rev. The pages change only in the notice line. The conformance docs now say generation holds the corpus and the harness, and each generator runs it against its own goldens.
…eatures.json

Not part of the repointing: the committed pages already lagged generation master (fixtures added since the last refresh), so the drift check fails on any change to the script. Separate commit so it can be dropped and merged on its own.
@Kinflou
Kinflou marked this pull request as ready for review November 16, 2026 15:33
@Kinflou
Kinflou merged commit 3d7a5f9 into main Nov 16, 2026
8 checks passed
@Kinflou
Kinflou deleted the features-split/per-generator-features branch November 16, 2026 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant