You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Generated @unverified docs can't name a third-party encoding's cause #93
Both generators call unverified::cause with Encodings::default(), because GenerateRequest carries no encoding declarations. So for a namespaced framing without vectors, the generated doc for @unverified can't name that cause.
Pass the visible FrozenUnit::Encoding declarations, or the per-protocol given-up causes, in the request (protocol 0, early days), and use them in comline-rust and comline-typescript.
ComlineProject/docs#162 (tracked in ComlineProject/core#219 and ComlineProject/core#222) would fix this from the schema side. A keyed @unverified gives each given-up guarantee its own reason, frozen with its scope, and the vocabulary gives the generated docs each guarantee's title and description. Generated docs could then say which cause belongs to which guarantee, a third-party encoding's included.
No longer applies. Neither generator calls unverified::cause any more: generation#136 (generation does not render causes itself), comline-rust#121 and comline-typescript#160 render the protocol's frozen guarantee set and per-guarantee reasons, with nothing recomputed from encodings (comline-rust unverified_doc in codegen/src/generator.rs). That is the schema-side fix described in the 2026-11-09 comment (core#219 / core#222). If generated docs should name a third-party encoding's cause as such, that is a new, narrower issue under core#222.
Activity
Kinflou commentedon Nov 9, 2026
ComlineProject/docs#162 (tracked in ComlineProject/core#219 and ComlineProject/core#222) would fix this from the schema side. A keyed
@unverifiedgives each given-up guarantee its own reason, frozen with its scope, and the vocabulary gives the generated docs each guarantee's title and description. Generated docs could then say which cause belongs to which guarantee, a third-party encoding's included.Kinflou commentedon Nov 15, 2026
No longer applies. Neither generator calls unverified::cause any more: generation#136 (generation does not render causes itself), comline-rust#121 and comline-typescript#160 render the protocol's frozen guarantee set and per-guarantee reasons, with nothing recomputed from encodings (comline-rust unverified_doc in codegen/src/generator.rs). That is the schema-side fix described in the 2026-11-09 comment (core#219 / core#222). If generated docs should name a third-party encoding's cause as such, that is a new, narrower issue under core#222.