Repository navigation
conformance: pin the generators at their entry-point revisions - #152
Merged
Merged
Conversation
…-bless the goldens comline-rust dd1c29e (entry-point header, doc(hidden) plumbing, Connection<T>/Framing aliases, Format and CONNECTION_IR_HASH defined once) and comline-typescript d377fbf (header, @internal plumbing, shared wire.ts). No wire value changes.
Kinflou
marked this pull request as ready for review
November 15, 2026 00:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins
conformance/Cargo.tomlat the merged generator heads and re-blesses the goldens (CONFORMANCE_BLESS=1 cargo test -p comline-conformance):2d2c885->dd1c29e6560a0ffd7893c59715b31d43b88c585f(comline-rust#131 entry-point header,#[doc(hidden)]plumbing,Connection<T>/Framingaliases,Format/CONNECTION_IR_HASHdefined once; includes Bump core to 35ab4b8 #132's STD_REV bump)c44b39d->d377fbf07cf6c0f004e9d5dd4fbd6fa15ea9d0bc(comline-typescript#172 header,@internalplumbing, sharedwire.ts)Both pin core
14ce546and generatione22109e, same as this branch's core pin.FEATURES.md/features.jsondid not change in the bless run, so they are untouched.Golden diff
Every changed line was reviewed (changed lines reduced to a unique-line histogram, then read). All of it falls in the allowed categories.
Rust: 33 of 43 files changed, +510/-230, no files added or removed.
//!entry-point header (28 files with header lines: the protocol files and the connection files).#[doc(hidden)]on plumbing items (83 top-level, 40 impl-level).useimports replacing fully qualifiedcomline_runtime::...paths (Transport,AsyncTransport,RuntimeError,Peer,Reason,Negotiated,Comline2Handshake,Json,JsonRpcFraming).pub type Framing(datagram@3,jsonrpc) andpub type Connection<T>aliases, and theaccept/connect/provide_onsignatures using them.FormatandCONNECTION_IR_HASHdefined inconnection.rs; 14 protocol filespub use crate::connection::{CONNECTION_IR_HASH, Format};and the jsonrpc one re-exportsCONNECTION_IR_HASHonly (it has noFormat).connectdoc ("run the handshake. Call the server's protocols through their senders." where there are no client services).TypeScript: 42 of 56 files changed (29 modified, +371/-289; 13 new
wire.ts, 182 lines).Where to start:with serve/dial/implement/call lines)./** @internal */on plumbing (57) and the@internalin doc blocks.wire.tsper package that has a connection (13):FormatandCONNECTION_IR_HASH.Format/CONNECTION_IR_HASHremoved from the per-protocol files and fromconnection.ts's own definition;connection.tsre-exports from./wire.js(export { CONNECTION_IR_HASH, Format } from "./wire.js") and imports it.connectdoc, "FormatandCONNECTION_IR_HASHare in./wire.js" pointer inprovideOndocs).Nothing outside those categories moved.
Wire invariance
A script extracted, per golden file, before (committed goldens at the merge base) and after (re-blessed): every
IR_HASH, theCONNECTION_IR_HASHvalue set per fixture and language (the definition moved files, so it is compared per fixture/language rather than per file), everyHELLObyte array, everyPROTOCOLnumber, every call id and name (Call::new(id, "name")and{ id, name }), every dispatcher arm id, andEnvelope::Err { id }ids, plus per-file occurrence counts of each.diff before.txt after.txtis empty: 425 lines each, sha2561754c461725ab8233ba806e6daa35ce59b21703c52a676cb779bf5dbb86cb8a7for both.Extraction script
Run as
python3 -I wire.py conformance/tests/golden > {before,after}.txt.CI is the check for the rest: the
comline-conformancetests (corpus_matches_golden,support_is_proven) run against the new pins.