Repository navigation
feat: carry the target's language version on GenRequest - #46
Merged
Merged
Conversation
added 2 commits
October 13, 2026 02:27
A generator knew which language version selected it only implicitly - the registry looked it up and then dropped it. So the Rust generator's `lib` mode had nothing to put in `Cargo.toml`'s `rust-version`, despite the target naming `rust#1.70.0` right there. `Mode::Code` has no manifest to record it in, and other generators ignore it the same way they ignore `default_framing` and `external_std`. Also bumps `comline-core` for the reserved-schema-name check (step 1 of the cascade); `codegen` itself is unaffected by it.
Step 3 of the cascade. The corpus builds a `GenRequest` directly, so it names each generator's own registered `LANG_VERSION` rather than one value shared across both - `Mode::Code` has no manifest to record it in, so no golden depends on it, but a request naming the wrong version would still be a lie about what is being asked for. The goldens do not move, which is the point: the new field reaches no generated code.
This was referenced Oct 12, 2026
Including comline-rust#38's STD_REV repoint, so a generated crate links the current comline_std rather than the one the previous pin named.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Steps 1 and 3 of the cascade for ComlineProject/core#91.
A generator knew which language version selected it only implicitly — the
registry looked it up and then dropped it. So the Rust generator's
libmodehad nothing to put in
Cargo.toml'srust-version, despite the targetnaming
rust#1.70.0right there.Mode::Codehas no manifest to record it in, and other generators ignore itthe same way they ignore
default_framingandexternal_std.The conformance corpus names each generator's own registered
LANG_VERSIONrather than one value shared across both — no golden depends on it, but a
request naming the wrong version would still be a lie about what is being
asked for. The goldens do not move, which is the check that matters: the
new field reaches no generated code.
Depends on ComlineProject/core#91, ComlineProject/comline-rust#37 and
ComlineProject/comline-typescript#31.