Skip to content

feat: carry the target's language version on GenRequest - #46

Merged
Kinflou merged 3 commits into
masterfrom
feat/gen-request-lang-version
Oct 12, 2026
Merged

Kinflou merged 3 commits into
masterfrom
feat/gen-request-lang-version

Conversation

@Kinflou

@Kinflou Kinflou commented Oct 12, 2026

Copy link
Copy Markdown
Member

Steps 1 and 3 of the cascade for ComlineProject/core#91.

A generator knew which language version selected it only implicitly — the
registry looked it up and then dropped it. So the Rust generator's lib mode
had nothing to put in Cargo.toml's rust-version, despite the target
naming rust#1.70.0 right there.

Mode::Code has no manifest to record it in, and other generators ignore it
the same way they ignore default_framing and external_std.

The conformance corpus names each generator's own registered LANG_VERSION
rather than one value shared across both — no golden depends on it, but a
request naming the wrong version would still be a lie about what is being
asked for. The goldens do not move, which is the check that matters: the
new field reaches no generated code.

Depends on ComlineProject/core#91, ComlineProject/comline-rust#37 and
ComlineProject/comline-typescript#31.

Kinflou added 2 commits October 13, 2026 02:27
A generator knew which language version selected it only implicitly - the
registry looked it up and then dropped it. So the Rust generator's `lib`
mode had nothing to put in `Cargo.toml`'s `rust-version`, despite the
target naming `rust#1.70.0` right there.

`Mode::Code` has no manifest to record it in, and other generators ignore
it the same way they ignore `default_framing` and `external_std`.

Also bumps `comline-core` for the reserved-schema-name check (step 1 of
the cascade); `codegen` itself is unaffected by it.
Step 3 of the cascade. The corpus builds a `GenRequest` directly, so it
names each generator's own registered `LANG_VERSION` rather than one value
shared across both - `Mode::Code` has no manifest to record it in, so no
golden depends on it, but a request naming the wrong version would still be
a lie about what is being asked for.

The goldens do not move, which is the point: the new field reaches no
generated code.
Including comline-rust#38's STD_REV repoint, so a generated crate links the
current comline_std rather than the one the previous pin named.
@Kinflou
Kinflou merged commit 11f0dab into master Oct 12, 2026
2 checks passed
@Kinflou
Kinflou deleted the feat/gen-request-lang-version branch October 12, 2026 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant